Skip to content

add deprecated comment to DOMAIN_SEPARATOR function #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nugi32 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add deprecated comment to DOMAIN_SEPARATOR function #6366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9b07be
add deprecated comment to DOMAIN_SEPARATOR function
nugi32 Feb 23, 2026
c84d162
fix: use @custom:deprecated NatSpec tag
nugi32 Feb 23, 2026
1a52df2
fix: correct NatSpec block structure
nugi32 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fiery-waves-move.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---

Deprecate DOMAIN_SEPARATOR in ERC20Permit.
1 change: 1 addition & 0 deletions contracts/token/ERC20/extensions/ERC20Permit.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ abstract contract ERC20Permit is ERC20, IERC20Permit, EIP712, Nonces {
}

/// @inheritdoc IERC20Permit
/// @custom:deprecated Use ERC-5267 (via {eip712Domain}) instead. This function will be removed in v6.0.
// solhint-disable-next-line func-name-mixedcase
function DOMAIN_SEPARATOR() external view returns (bytes32) {
return _domainSeparatorV4();
Expand Down
2 changes: 2 additions & 0 deletions contracts/token/ERC20/extensions/IERC20Permit.sol
View file
Open in desktop
Copy link
Copy Markdown
Collaborator

@Amxx Amxx Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DOMAIN_SEPARATOR function is part of ERC-2612. We cannot just remove it from here

Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ interface IERC20Permit {

/**
* @dev Returns the domain separator used in the encoding of the signature for {permit}, as defined by {EIP712}.
*
* @custom:deprecated Use ERC-5267 (via {eip712Domain}) instead. This function will be removed in v6.0.
*/
// solhint-disable-next-line func-name-mixedcase
function DOMAIN_SEPARATOR() external view returns (bytes32);
Expand Down
Loading
Loading