-
Notifications
You must be signed in to change notification settings - Fork 186
Update linters (major) #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe eslint-plugin-unicorn devDependency version constraint was updated from ^61.0.0 to ^62.0.0 in package.json. This allows the package manager to install compatible versions within the 62.x release series. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: boostsecurity - boostsecurityio/semgrep-pro
- GitHub Check: build (stylus, default)
- GitHub Check: build (solidity, default)
- GitHub Check: build (stellar, default)
- GitHub Check: build (cairo, default)
- GitHub Check: build (stellar, compile)
- GitHub Check: ui
- GitHub Check: mcp
- GitHub Check: format-lint
- GitHub Check: check
- GitHub Check: deno-check
- GitHub Check: semgrep-cloud-platform/scan
package.json
Outdated
| "eslint-config-prettier": "^10.1.1", | ||
| "eslint-plugin-prettier": "^5.2.6", | ||
| "eslint-plugin-unicorn": "^61.0.0", | ||
| "eslint-plugin-unicorn": "^62.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify eslint-plugin-unicorn v62 breaking changes and config compatibility.
This is a major version bump (v61 → v62) for a linter plugin. Major version updates often introduce breaking changes, rule removals, or behavioral changes that may require eslint configuration updates or could cause lint failures.
Please verify:
- Whether v62.0.0 introduces breaking changes (check the release notes)
- Whether any eslint configuration updates are needed in
.eslintrcfiles or linter configs - Whether the
lintscript (eslint) will pass without errors with v62.0.0
If breaking changes exist, ensure that related configuration changes have been applied to the repository before merging.
🌐 Web query:
What are the breaking changes in eslint-plugin-unicorn v62.0.0 compared to v61?
💡 Result:
I couldn't find any release notes or a published v62.0.0 for eslint-plugin-unicorn. The official repo (sindresorhus/eslint-plugin-unicorn) and release listings don't show a v62 tag/releases, and the latest changelog I located is for v60.0.0. [1][2]
If you have a specific release URL or tag for v62 (or want me to keep searching other sources), share it and I’ll fetch the breaking changes and summarize them.
Sources:
- eslint-plugin-unicorn GitHub repo. [1]
- v60.0.0 changelog listing. [2]
🏁 Script executed:
#!/bin/bash
# Check the actual package.json content for eslint-plugin-unicorn version
cat package.json | grep -A2 -B2 "eslint-plugin-unicorn"Length of output: 186
🏁 Script executed:
#!/bin/bash
# Query npm registry for eslint-plugin-unicorn versions (check latest and v62 specifically)
curl -s https://registry.npmjs.org/eslint-plugin-unicorn | jq '.versions | keys | sort | .[-10:]'Length of output: 114
🏁 Script executed:
#!/bin/bash
# Check npm registry for v62 specifically
curl -s https://registry.npmjs.org/eslint-plugin-unicorn/62.0.0 | jq 'if .error then "Version not found" else .version end'Length of output: 8
---
🏁 Script executed:
```shell
#!/bin/bash
# Find eslint configuration files in the repository
fd -t f -e json -e js -e yml -e yaml -e mjs -e cjs -g '*eslintrc*' .
Length of output: 0
🏁 Script executed:
#!/bin/bash
# Also check for common eslint config locations
find . -maxdepth 2 -type f \( -name ".eslintrc*" -o -name "eslint.config.*" \) 2>/dev/nullLength of output: 19
🌐 Web query:
eslint-plugin-unicorn v62.0.0 changelog breaking changes
💡 Result:
There is no published eslint-plugin-unicorn v62.0.0 release. The latest published release series on npm/GitHub is v61 (most-recent tags show v61.x in Sep 2025), and npm's package page lists v60/v59 as recent stable releases. See the release list and npm info. [1][2]
Sources:
- Release list for eslint-plugin-unicorn (shows up through v61.x). [1]
- npm package page for eslint-plugin-unicorn (latest published versions). [2]
🏁 Script executed:
#!/bin/bash
# Check npm package metadata for v62.0.0 to see if it's a pre-release
curl -s https://registry.npmjs.org/eslint-plugin-unicorn/62.0.0 | jq '{version, dist_tags: .["dist-tags"], prerelease: (.version | contains("-")), published: .time["62.0.0"]}'Length of output: 90
🏁 Script executed:
#!/bin/bash
# Check eslint.config.mjs to see which rules are configured
cat eslint.config.mjsLength of output: 1348
Revert eslint-plugin-unicorn to stable v61 release; v62.0.0 is unreleased.
The version v62.0.0 exists on npm but is marked as unreleased (null published timestamp, no dist tags, not listed on GitHub releases). While the config imports eslint-plugin-unicorn, it doesn't explicitly enable any unicorn rules—so breaking changes wouldn't immediately break linting—using an unreleased, undocumented version introduces unnecessary stability risk.
Revert to the latest stable version: "eslint-plugin-unicorn": "^61.0.2"
🤖 Prompt for AI Agents
In package.json around line 37, the dependency "eslint-plugin-unicorn":
"^62.0.0" references an unreleased/unstable npm version; change it back to the
latest stable release by replacing the version string with "^61.0.2" so the
project uses the documented stable unicorn plugin; update package-lock/yarn.lock
by running the appropriate install command afterwards to ensure the lockfile
reflects the reverted version.
006650e to
736220a
Compare
190907f to
b993a52
Compare
d99213d to
94033eb
Compare
d465b3b to
4501d66
Compare
62775a5 to
7f5aa44
Compare
121e477 to
dd149ba
Compare
dd149ba to
7ed2e40
Compare
9a25c17 to
9c5b068
Compare
2c449fd to
c3ecc92
Compare
473b008 to
45f0ad6
Compare
0f1226a to
6a9cd57
Compare
6a9cd57 to
b507930
Compare
b507930 to
43b0bbf
Compare
This PR contains the following updates:
^9.33.0→^10.0.0^61.0.0→^63.0.0Release Notes
eslint/eslint (eslint)
v10.0.0Compare Source
v9.39.2Compare Source
v9.39.1Compare Source
v9.39.0Compare Source
v9.38.0Compare Source
Features
ce40f74feat: updatecomplexityrule to only highlight function header (#20048) (Atul Nair)e37e590feat: correctno-loss-of-precisionfalse positives withenotation (#20187) (Francesco Trotta)Bug Fixes
50c3dfdfix: improve type support for isolated dependencies in pnpm (#20201) (Francesco Trotta)a1f06a3fix: correct SourceCode typings (#20114) (Pixel998)Documentation
462675adocs: improve web accessibility by hiding non-semantic character (#20205) (루밀LuMir)c070e65docs: correct formatting inno-irregular-whitespacerule documentation (#20203) (루밀LuMir)b39e71adocs: Update README (GitHub Actions Bot)cd39983docs: movecustom-formatterstype descriptions tonodejs-api(#20190) (Percy Ma)Chores
d17c795chore: upgrade @eslint/js@9.38.0 (#20221) (Milos Djermanovic)25d0e33chore: package.json update for @eslint/js release (Jenkins)c82b5efrefactor: Use types from @eslint/core (#20168) (Nicholas C. Zakas)ff31609ci: add Node.js 25 toci.yml(#20220) (루밀LuMir)004577eci: bump github/codeql-action from 3 to 4 (#20211) (dependabot[bot])eac71fbtest: remove use ofnodejsScopeoption of eslint-scope from tests (#20206) (Milos Djermanovic)4168a18chore: fix typo in legacy-eslint.js (#20202) (Sweta Tanwar)205dbd2chore: fix typos (#20200) (ntnyq)dbb200echore: use team member's username when name is not available in data (#20194) (Milos Djermanovic)8962089chore: mark deprecated rules as available until v11.0.0 (#20184) (Pixel998)v9.37.0Compare Source
Features
39f7fb4feat:preserve-caught-errorshould recognize all static "cause" keys (#20163) (Pixel998)f81eabcfeat: support TS syntax inno-restricted-imports(#19562) (Nitin Kumar)Bug Fixes
a129ccefix: correctno-loss-of-precisionfalse positives for leading zeros (#20164) (Francesco Trotta)09e04fcfix: add missing AST token types (#20172) (Pixel998)861c6dafix: correctESLinttypings (#20122) (Pixel998)Documentation
b950359docs: fix typos across the docs (#20182) (루밀LuMir)42498a2docs: improve ToC accessibility by hiding non-semantic character (#20181) (Percy Ma)29ea092docs: Update README (GitHub Actions Bot)5c97a04docs: showavailableUntilin deprecated rule banner (#20170) (Pixel998)90a71bfdocs: updateREADMEfiles to add badge and instructions (#20115) (루밀LuMir)1603ae1docs: update references frommastertomain(#20153) (루밀LuMir)Chores
afe8a13chore: update@eslint/jsdependency to version 9.37.0 (#20183) (Francesco Trotta)abee4cachore: package.json update for @eslint/js release (Jenkins)fc9381fchore: fix typos in comments (#20175) (overlookmotel)e1574a2chore: unpin jiti (#20173) (renovate[bot])e1ac05erefactor: markESLint.findConfigFile()asasync, add missing docs (#20157) (Pixel998)347906dchore: update eslint (#20149) (renovate[bot])0cb5897test: remove tmp dir created for circular fixes in multithread mode test (#20146) (Milos Djermanovic)bb99566ci: pinjitito version 2.5.1 (#20151) (Pixel998)177f669perf: improve worker count calculation for"auto"concurrency (#20067) (Francesco Trotta)448b57bchore: Mark deprecated formatting rules as available until v11.0.0 (#20144) (Milos Djermanovic)v9.36.0Compare Source
Features
47afcf6feat: correctpreserve-caught-erroredge cases (#20109) (Francesco Trotta)Bug Fixes
75b74d8fix: add missing rule option types (#20127) (ntnyq)1c0d850fix: updateeslint-all.jsto useObject.freezeforrulesobject (#20116) (루밀LuMir)7d61b7ffix: add missing scope types toScope.type(#20110) (Pixel998)7a670c3fix: correct rule option typings inrules.d.ts(#20084) (Pixel998)Documentation
b73ab12docs: update examples to usedefineConfig(#20131) (sethamus)31d9392docs: fix typos (#20118) (Pixel998)c7f861bdocs: Update README (GitHub Actions Bot)6b0c08bdocs: Update README (GitHub Actions Bot)91f97c5docs: Update README (GitHub Actions Bot)Chores
12411e8chore: upgrade @eslint/js@9.36.0 (#20139) (Milos Djermanovic)488cba6chore: package.json update for @eslint/js release (Jenkins)bac82a2ci: simplify renovate configuration (#19907) (唯然)c00bb37ci: bump actions/labeler from 5 to 6 (#20090) (dependabot[bot])fee751drefactor: usedefaultOptionsin rules (#20121) (Pixel998)1ace67dchore: update example to usedefineConfig(#20111) (루밀LuMir)4821963test: add missing loc information to error objects in rule tests (#20112) (루밀LuMir)b42c42echore: disallow use of deprecatedtypeproperty in core rule tests (#20094) (Milos Djermanovic)7bb498dtest: remove deprecatedtypeproperty from core rule tests (#20093) (Pixel998)e10cf2aci: bump actions/setup-node from 4 to 5 (#20089) (dependabot[bot])5cb0ce4refactor: usemeta.defaultOptionsinpreserve-caught-error(#20080) (Pixel998)f9f7cb5chore: package.json update for eslint-config-eslint release (Jenkins)81764b2chore: updateeslintpeer dependency ineslint-config-eslint(#20079) (Milos Djermanovic)v9.35.0Compare Source
Features
42761fafeat: implement suggestions for no-empty-function (#20057) (jaymarvelz)102f444feat: implement suggestions for no-empty-static-block (#20056) (jaymarvelz)e51fffffeat: addpreserve-caught-errorrule (#19913) (Amnish Singh Arora)Bug Fixes
10e7ae2fix: update uncloneable options error message (#20059) (soda-sorcery)bfa4601fix: ignore empty switch statements with comments in no-empty rule (#20045) (jaymarvelz)dfd11defix: addbeforeandafterto test case types (#20049) (Francesco Trotta)dabbe95fix: correct types forno-restricted-importsrule (#20034) (Milos Djermanovic)ea789c7fix: no-loss-of-precision false positive with uppercase exponent (#20032) (sethamus)Documentation
d265515docs: improve phrasing - "if" → "even if" from getting-started section (#20074) (jjangga0214)a355a0edocs: invert comparison logic for example inno-vardoc page (#20064) (OTonGitHub)5082fc2docs: Update README (GitHub Actions Bot)99cfd7edocs: add missing "the" in rule deprecation docs (#20050) (Josh Goldberg ✨)6ad8973docs: update--no-ignoreand--ignore-patterndocumentation (#20036) (Francesco Trotta)8033b19docs: add documentation for--no-config-lookup(#20033) (Francesco Trotta)Chores
da87f2fchore: upgrade @eslint/js@9.35.0 (#20077) (Milos Djermanovic)af2a087chore: package.json update for @eslint/js release (Jenkins)7055764test: removetests/lib/eslint/eslint.config.js(#20065) (Milos Djermanovic)84ffb96chore: update@eslint-community/eslint-utils(#20069) (Francesco Trotta)d5ef939refactor: remove deprecatedcontext.parserOptionsusage across rules (#20060) (sethamus)1b3881dchore: remove redundant word (#20058) (pxwanglu)v9.34.0Compare Source
Features
0bb777afeat: multithread linting (#19794) (Francesco Trotta)43a5f9efeat: add eslint-plugin-regexp to eslint-config-eslint base config (#19951) (Pixel998)Bug Fixes
9b89903fix: default value of accessor-pairs option in rule.d.ts file (#20024) (Tanuj Kanti)6c07420fix: fix spurious failure in neostandard integration test (#20023) (Kirk Waiblinger)676f4acfix: allow scientific notation with trailing zeros matching exponent (#20002) (Sweta Tanwar)Documentation
0b4a590docs: make rulesdir deprecation clearer (#20018) (Domenico Gemoli)327c672docs: Update README (GitHub Actions Bot)bf26229docs: Fix typo in core-concepts/index.md (#20009) (Tobias Hernstig)2309327docs: fix typo in the "Configuring Rules" section (#20001) (ghazi-git)2b87e21docs: [no-else-return] clarify sample code. (#19991) (Yuki Takada (Yukinosuke Takada))c36570cdocs: Update README (GitHub Actions Bot)Chores
f19ad94chore: upgrade to@eslint/js@9.34.0(#20030) (Francesco Trotta)b48fa20chore: package.json update for @eslint/js release (Jenkins)4bce8a2chore: package.json update for eslint-config-eslint release (Jenkins)0c9999crefactor: prefer default options ingrouped-accessor-pairs(#20028) (루밀LuMir)d503f19ci: fixstale.yml(#20010) (루밀LuMir)e2dc67dci: centralizestale.yml(#19994) (루밀LuMir)7093cb8ci: bump actions/checkout from 4 to 5 (#20005) (dependabot[bot])sindresorhus/eslint-plugin-unicorn (eslint-plugin-unicorn)
v63.0.0Compare Source
New rules
isolated-functions(#2701)4956a6bImprovements
bd0901bprefer-set-size: AddArray.from()support (#2857)e556143prefer-bigint-literals: Support signed numbers and strings (#2784)a332a50prefer-export-from: Fix type-import being removed when using namespace import (#2771)ab4b779prefer-spread: Fix: Skip TypedArray and ArrayBuffer constructor calls (#2871)42a558fno-array-sort: Ignore.sort()calls with non-function arguments (#2862)cbb2377prefer-add-event-listener: Don't autofix non-function assignments (#2865)989ec61explicit-length-check: Ignore||with string fallback value (#2861)4806f7eno-unnecessary-polyfills: Fix false positive for graduatedesnextfeatures (#2864)d6c13abno-for-loop: Skip auto-fix for string types when.entries()would be needed (#2869)08a591aimport-style: Fix crash onexport {x}withoutfromclause (#2868)141c8c5expiring-todo-comments: Should not flag ESLint disable comments (#2828)3568dafno-useless-collection-argument: Use suggestions to remove empty array with comments (#2838)c0d0687prefer-set-has: CheckIterator#toArray()andString#split()(#2829)ab8970eno-useless-spread: Fix false positive onIterator(#2831)994e31cisolated-functions: Ignore TypeScript types (#2822)c3479c0prefer-string-raw: Exclude inline snapshot (#2811)6e7f93cconsistent-assert: Explicitly check specifier node type (#2803)396a8fav62.0.0Compare Source
New rules
no-immediate-mutation(#2787)e1c7d2eno-useless-collection-argument(#2777)2d07c9aprefer-response-static-json(#2778)ffe5943Improvements
text-encoding-identifier-case: AddwithDashoption (#2780)9025386no-useless-undefined: Check oneundefinedat a time (#2792)27f7509prefer-single-call: Check optional chaining (#2788)8a132actext-encoding-identifier-case: Enforce'utf-8'inform[acceptCharset]andTextDecoder(#2785)46b3974prefer-node-protocol: Handle TypeScript import types (#2774)13a37a0no-array-for-each: IgnoreforEachfor Effect library (#2783)2ef6f83prefer-string-raw: Ignore more places that requires a string (#2776)43bc429prefer-string-raw: Add support for template literals (#2691)52723a2prefer-global-this: AddnavigationtowindowSpecificAPIs(#2770)0c93998prefer-code-point: Report cases whereString.fromCharCodeis not called directly (#2766)1d682a1no-useless-spread: Safely remove empty array and object (#2764)7aeababFixes
consistent-function-scoping: Fix inconsistent behavior (#2748)a546444Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.