Draft
Conversation
ericglau
reviewed
Jul 3, 2025
Member
ericglau
left a comment
ericglau
left a comment
There was a problem hiding this comment.
Overall this looks like a good approach.
| `}`, | ||
| `return instance;`, | ||
| ]).split('\n'), | ||
| { name: 'create', kind: 'public' as const, args, returns: [ 'address' ] }, |
Member
There was a problem hiding this comment.
The function name is create but the cloning is using create2. These don't need to match but should we make it clearer that this deploys accounts using create2?
…to feature/solidity-account-factory
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.