Skip to content

Comments

refpolicy fixes#1480

Merged
crogers1 merged 6 commits intoOpenXT:masterfrom
jandryuk:refpolicy-fixes-2
Nov 9, 2023
Merged

refpolicy fixes#1480
crogers1 merged 6 commits intoOpenXT:masterfrom
jandryuk:refpolicy-fixes-2

Conversation

@jandryuk
Copy link
Contributor

A few refpolicy fixes after the recent refpolicy uprev.

6ca7754 is a cherry-pick of ba7da75 from #1445

dd43713 is no longer applicable after the

Boot shows 4 denials of xec_t using init_t fds.  The vglass initscript
uses xec to query gpu configuration over dbus.  xec doesn't need to
access the FDs, so quiet them with a dontaudit.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
The .fc file has the incorrect /etc/init.d/udev path, when it needs to
be /etc/rc.d/init.d/udev to label the file properly.  It's been ending
up as initrc_exec_t and things (mostly) work.

Remove the dead code.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
We see the following denial:
avc:  denied  { read write } for  pid=74 comm="udevadm" path="/dev/console" dev="devtmpfs" ino=9 scontext=system_u:system_r:udevadm_t:s0 tcontext=system_u:object_r:device_t:s0 tclass=chr_file permissive=0

udevadm is run during boot.  device_t shows that /dev/console has not
been labeled yet.

The 20200229 refpolicy uprev introduced udevadm_t - previously it ran as
udev_t.  Add a dontaudit to keep the logs clean.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Backport the upstream udev watch patch and remove our customization.  It
labels the files under lib_t, so it doesn't need a watch on lib_t:dir.

The patch comes from 2.20220520.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
WARNING: preferred version 2.20200229 of refpolicy-mcs not available (for item refpolicy-mcs)
WARNING: versions of refpolicy-mcs available: 2.20200229+gitAUTOINC+613708cad6

We only have one now, so just remove the preferred version line.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Having a non-zero value is deprecated and it was removed in Linux 6.4.
Testing without it, everything seems to work.  Drop it.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Copy link
Contributor

@crogers1 crogers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging soon.

@crogers1 crogers1 merged commit f5d16ed into OpenXT:master Nov 9, 2023
@jandryuk jandryuk deleted the refpolicy-fixes-2 branch November 13, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants