-
Notifications
You must be signed in to change notification settings - Fork 0
Multiple fixes - not ideal to be combined in a single PR, but here we are. #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rmpel
wants to merge
8
commits into
main
Choose a base branch
from
fix/RP20250730
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
389d095
Contact requests should not go through info@acato.nl. A better option…
rmpel c7ce9c3
Add NPM commands for i18n management.
rmpel 291a9e0
Update POT, add translations and update the compiled files.
rmpel 10f797b
The fix that started this entire PR - Early Output breaking the websi…
rmpel b95ac62
Reformat comments to shopw better in Github.
rmpel 65f02a6
Rebalance whitespace in package.json
rmpel 4f42695
Removing error message when MO file is not found
rmpel 84ede26
Add --no-purge to make-json because for some stupid reason, WordPress…
rmpel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
languages/openkaarten-frontend-plugin-nl_NL-a6d89d02facc49d2994e1a4275125118.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {"translation-revision-date":"2024-08-13 16:54+0200","generator":"WP-CLI\/2.8.1","source":"src\/blocks\/owc-openkaarten\/streetmap\/assets\/scripts\/edit.js","domain":"messages","locale_data":{"messages":{"":{"domain":"messages","lang":"nl_NL","plural-forms":"nplurals=2; plural=(n != 1);"},"Select the datalayers you want to display on the map":["Selecteer de datalayers die getoond dienen te worden op de kaart"],"No datalayers selected":["Geen datalayers geselecteerd"],"Select datalayers:":["Selecteer datalayers"],"Selected datalayers":["Geselecteerde datalayers"]}}} | ||
| {"translation-revision-date":"2024-08-13 16:54+0200","generator":"WP-CLI\/2.12.0","source":"src\/blocks\/owc-openkaarten\/streetmap\/assets\/scripts\/edit.js","domain":"messages","locale_data":{"messages":{"":{"domain":"messages","lang":"nl_NL","plural-forms":"nplurals=2; plural=(n != 1);"},"Invalid URL":["Ongeldige URL"],"Error parsing nested JSON":["Fout bij het parsen van geneste JSON"],"Unexpected response format or 'datasets' is not an array.":["Onverwachte opbouw van antwoord, of 'datasets' is geen array."],"Fetching datasets failed":["Het ophalen van datasets is mislukt"],"Select the datalayers you want to display on the map":["Selecteer de datalagen die u op de kaart wilt weergeven"],"No datalayers found":["Geen datalagen gevonden"],"No datalayers selected":["Geen datalagen geselecteerd"],"URL to rest-endpoint or Domain URL":["URL naar rest-eindpunt of domein-URL"],"Select datalayers:":["Selecteer datalagen:"],"Selected datalayers":["Geselecteerde datalagen"],"URL template for tile layer":["URL-sjabloon voor tegel-laag"]}}} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| <?php | ||
| return ['domain'=>'openkaarten-frontend-plugin','plural-forms'=>NULL,'language'=>'nl_NL','project-id-version'=>'OpenKaarten Frontend Plugin 0.1.0','pot-creation-date'=>'2024-06-13T09:17:05+00:00','po-revision-date'=>'2024-08-13 16:54+0200','x-generator'=>'Poedit 3.4.1','messages'=>['Adds OpenKaarten Blocks to the Gutenberg editor.'=>'Voegt OpenKaarten blokken toe aan de Gutenberg editor.','OpenKaarten Blocks'=>'OpenKaarten blokken','block titleOWC Openmaps Openstreet Map'=>'OpenKaarten Openstreetmap Kaart','block descriptionOWC Openmaps Openstreet Map'=>'OpenKaarten Openstreetmap Kaart','block keywordopenmaps'=>'openkaarten','block keywordmap'=>'kaart','block keywordlocations'=>'locaties']]; |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Klopt dit wel? Er worden nu Nederlandse vertalingen verwijderd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ik zal kijken wat ik kan repareren, maar bijvoorbeeld de string "Select the datalayers you want to display on the map" zit niet in het PO bestand in
main. gezien ik afgetakt ben vanmain...Hoe het in de JSON terecht gekomen is, is mij onbekend, maar er zijn 2 wijzigingen in de PO file op main
1 is de initiele opzet van jou; zit deze string niet in
2 is een eerdere merge van mij, die niet aan deze tekst iets wijzigt (want wat er niet is kun je niet wijzigen)
Wederom een vertaal-bestand-raadsel ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm run make-json verwijderd de missende regels uit de PO file ... - investigating ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, please re-review @richardkorthuis