Skip to content

Conversation

@xiaoxustudio
Copy link
Contributor

@xiaoxustudio xiaoxustudio commented Nov 10, 2025

@gemini-code-assist
Copy link

Summary of Changes

Hello @xiaoxustudio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances text box rendering capabilities by introducing two new configuration parameters: Max_line and Max_lineHeight. These additions provide developers with more granular control over how text is displayed within text boxes, allowing for custom line limits and line spacing. The changes are reflected across the multi-language documentation to ensure clarity for all users.

Highlights

  • New Configuration Parameters: Introduced Max_line to limit the number of lines in a text box, with default logic applied if not set.
  • Text Box Line Height Control: Added Max_lineHeight to specify the height of each line in a text box, which becomes effective when Max_line is enabled, using 'em' as the unit.
  • Documentation Updates: Updated the configuration documentation in Chinese, English, and Japanese to include the descriptions for the new Max_line and Max_lineHeight parameters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for two new configuration parameters, Max_line and Max_lineHeight, across Chinese, English, and Japanese versions of the configuration guide. The updates are a good addition, but the descriptions could be improved for clarity and conciseness in all languages. In particular, the Japanese translations for the new parameters seem incorrect and should be revised to be more natural and understandable. I've provided specific suggestions for all three files to improve the documentation.

xiaoxustudio and others added 5 commits November 16, 2025 15:44
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@MakinoharaShoko
Copy link
Member

现在应该不再有 Max_lineHeight 这个配置项
image

@xiaoxustudio xiaoxustudio changed the title feat: add Max_line and Max_lineHeight feat: add Max_lineHeight Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants