Skip to content

allow unencrypted puppetdb http://127.0.0.1 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schlitzered wants to merge 4 commits into
base: main
Choose a base branch
from
Open

allow unencrypted puppetdb http://127.0.0.1 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4150db4
allow unencrypted puppetdb http://127.0.0.1
schlitzered Dec 12, 2025
c2f539d
add test that checks for http://127.0.0.1
schlitzered Dec 12, 2025
ed67c8d
Merge branch 'main' into feature_allow_http_puppetdb_on_localhost
schlitzered Dec 16, 2025
08d89f3
Merge branch 'main' into feature_allow_http_puppetdb_on_localhost
schlitzered Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion puppet/lib/puppet/util/puppetdb/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ def self.convert_and_validate_urls(uri_strings)
raise URI::InvalidURIError.new, "Error parsing URL '#{uri_string}' in PuppetDB 'server_urls', error message was '#{e.message}'"
end

if uri.scheme != 'https'
allow_http = (uri.scheme == 'http' && uri.host == '127.0.0.1')
if uri.scheme != 'https' && !allow_http
raise "PuppetDB 'server_urls' must be https, found '#{uri_string}'"
end

Expand Down
10 changes: 10 additions & 0 deletions puppet/spec/unit/util/puppetdb/config_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,16 @@ def write_config(content)
end.to raise_error(/PuppetDB 'server_urls' cannot contain URL paths, found 'https:\/\/foo.something-different.com\/bar'/)
end

it "allows http for 127.0.0.1" do
write_config <<CONF
[main]
server_urls = http://127.0.0.1:8080
CONF

config = described_class.load
expect(config.server_urls).to eq([URI("http://127.0.0.1:8080")])
end

it "should fail if given a server/port combo" do
write_config <<CONF
[main]
Expand Down