Drop multi_json support #293
Open
+12
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These days the built in JSON is fast enough and supporting other implementations can only complicate matters. We can also rely on JRuby to have a correct implementation since the same json gem is also built for Java and included in JRuby.
bastelfreak
reviewed
Dec 28, 2025
| end | ||
|
|
||
| begin | ||
| require 'multi_json' |
Contributor
There was a problem hiding this comment.
mental note: we probably can/have to adjust puppet-runtime or openvox-server to not include multi_json in the packages
bastelfreak
approved these changes
Dec 28, 2025
jay7x
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These days the built in JSON is fast enough and supporting other implementations can only complicate matters. We can also rely on JRuby to have a correct implementation since the same json gem is also built for Java and included in JRuby.
Note I made an assumption about JRuby because https://rubygems.org/gems/json also lists a Java build.
I was triggered to drop this because tests started to fail for me.