Generate the reference from the runmode #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Dec 28, 2025
Contributor
Author
|
I had a hard time with the tests. I could file a bug on multi_json but opened #293 instead |
Contributor
|
@ekohl can you rebase please? |
This uses fewer variables and is a bit shorter which arguably is making it easier to read.
This avoids duplicating the values with the actual logic.
ekohl
force-pushed
the
read-paths-from-runmode
branch
from
0c613fe to
f282a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids duplicating the values with the actual logic.
The motivation is to fully centralize all OS specific paths in
RunMode. If packaging decides to change it (like in #225) then it is limited to a single file.