Unify java options, remove PE stuff #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the java options simpler by allowing any LTS (including the upcoming 25) as a dependency on the package, choosing the oldest supported one available. This also removes some code paths that were for PE.
ekohl
requested changes
Apr 16, 2025
| options.old_sles = 0 | ||
| options.sles = 0 | ||
| options.java = 'java-1.8.0-openjdk-headless' | ||
| options.java = 'java-11-openjdk-headless | java-17-openjdk-headless | java-21-openjdk-headless | java-25-openjdk-headless' |
Contributor
There was a problem hiding this comment.
This ends up in the Fedora case and this isn't valid for Fedora because it's the Debian syntax.
Contributor
|
@nmburgan could you please rebase it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the java options simpler by allowing any LTS (including the upcoming 25) as a dependency on the package, choosing the oldest supported one available. This also removes some code paths that were for PE.