Conversation
- build_tests.yml: remove paths filter (now runs on all PRs); add package_name
and version_file for channel compatibility check
- release_preview.yml: add package_name and version_file for channel check
- unit_tests.yml: fix install_extras ("-e .[pydantic]" -> "[pydantic]");
remove push trigger and paths-ignore so coverage always posts on PRs
- release_workflow.yml: remove redundant github.ref guard on job conditions
- downstream_check.yml: new workflow
- python_support.yml: removed (superseded by build-tests.yml)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
build-tests.yml no longer uses these (channel check was removed from the reusable workflow). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
At your service! I've gathered all the check results for you. 🫡I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthScanning for any signs of 'deprecated' acne. 🧴 ✅ All required files present. Latest Version: ✅ ⚖️ License CheckI've checked for any conflicting terms of service. 📜 ✅ No license violations found (60 packages). License distribution: 14× MIT, 14× MIT License, 9× Apache Software License, 4× Apache-2.0, 4× BSD-3-Clause, 2× ISC License (ISCL), 2× PSF-2.0, 2× Python Software Foundation License, +8 more Full breakdown — 60 packages
Copyright (c) 2022 Phil Ewels Permission is hereby granted, free of charge, to any person obtaining a copy The above copyright notice and this permission notice shall be included in all THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🏷️ Release PreviewI've checked the 'Performance Improvements' metrics. 📈 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
🔒 Security (pip-audit)Security check! Are we safe from vulnerabilities? 🛡️ ✅ No known vulnerabilities found (68 packages scanned). 🔨 Build TestsEnsuring the gears are properly lubricated. 💧 ✅ All versions pass
📊 CoverageA comprehensive review of our code coverage. 📖 Per-file coverage (4 files)
Full report: download the Automating the boring stuff so you don't have to! 🚀 |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (5)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Around line 27-28: The unit tests workflow call for the reusable coverage
workflow is missing the install_extras parameter, so the dev pydantic dependency
isn't installed; update the reusable workflow invocation in unit_tests.yml to
add a with: block that includes python_version: "3.14" and install_extras:
'[dev]' (ensure the keys are named exactly install_extras and python_version) so
the coverage workflow installs development extras when running tests like
test/unittests/test_pydantic_helpers.py.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0d43e9e8-bfd4-49ba-804c-a104f94325cd
📒 Files selected for processing (3)
.github/workflows/release_workflow.yml.github/workflows/unit_tests.ymlpyproject.toml
💤 Files with no reviewable changes (2)
- .github/workflows/release_workflow.yml
- .github/workflows/unit_tests.yml
- unit_tests.yml: coverage + PR comment on pull_request (permissions: pr write) - coverage_pages.yml: coverage + GitHub Pages on push to dev (permissions: pages, id-token) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: docs, tests and some tiny improvements (#30) * feat: docs, tests and some tiny improvements * feat: docs, tests and some tiny improvements * feat: docs, tests and some tiny improvements * Increment Version to * Add renovate.json (#29) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Increment Version to * Update Changelog * feat: Add language customization and expanded test coverage (#35) * feat: docs, tests and some tiny improvements * feat: docs, tests and some tiny improvements * feat: docs, tests and some tiny improvements * feat: add multilingual testing support and fix from_message bugs - MiniCroft: added `lang` and `secondary_langs` params to patch Configuration() before IntentService init, enabling Adapt/Padatious to register vocab for multiple languages - End2EndTest.from_message(): fixed crash when async_messages=None - End2EndTest.from_message(): added ignore_gui param (default True) to filter GUI namespace messages during fixture recording - End2EndTest.from_message(): now passes ignore_messages, eof_msgs, async_messages to the returned End2EndTest object - Updated docs/minicroft.md with new constructor params and Multilingual Testing section Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: tests * chore: tests * chore: tests * coderabbitt * tests * tests * update * coderrabbit * coderrabbit * . * ci: update workflows for gh-automations refactor - build_tests.yml: remove paths filter (now runs on all PRs); add package_name and version_file for channel compatibility check - release_preview.yml: add package_name and version_file for channel check - unit_tests.yml: fix install_extras ("-e .[pydantic]" -> "[pydantic]"); remove push trigger and paths-ignore so coverage always posts on PRs - release_workflow.yml: remove redundant github.ref guard on job conditions - downstream_check.yml: new workflow - python_support.yml: removed (superseded by build-tests.yml) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * . * chore: remove unused package_name/version_file inputs from build_tests build-tests.yml no longer uses these (channel check was removed from the reusable workflow). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix: standardize CI workflows for release readiness - release_workflow.yml: replace inline build_tests job with reusable build-tests.yml@dev (runs full matrix 3.10-3.14, uses wheel install) - unit_tests.yml: fix install_extras — was '[pydantic]' (invalid pip arg), now 'ovoscope[pydantic]' which reinstalls with the optional extra after coverage.yml's editable install Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * gitignore --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * Update downstream dependency report for ovoscope * Increment Version to 0.9.0a1 * Update Changelog * drop pycache * fix: clean up CI/CD — remove release gate, fix pydantic install (#36) * feat: docs, tests and some tiny improvements * feat: docs, tests and some tiny improvements * chore: tests * chore: tests * tests * tests * coderrabbit * ci: update workflows for gh-automations refactor - build_tests.yml: remove paths filter (now runs on all PRs); add package_name and version_file for channel compatibility check - release_preview.yml: add package_name and version_file for channel check - unit_tests.yml: fix install_extras ("-e .[pydantic]" -> "[pydantic]"); remove push trigger and paths-ignore so coverage always posts on PRs - release_workflow.yml: remove redundant github.ref guard on job conditions - downstream_check.yml: new workflow - python_support.yml: removed (superseded by build-tests.yml) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore: remove unused package_name/version_file inputs from build_tests build-tests.yml no longer uses these (channel check was removed from the reusable workflow). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix: remove duplicate coverage_source line in unit_tests.yml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: split coverage into PR checks and Pages deployment - unit_tests.yml: coverage + PR comment on pull_request (permissions: pr write) - coverage_pages.yml: coverage + GitHub Pages on push to dev (permissions: pages, id-token) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * cov --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * Increment Version to 0.9.1a1 * Update Changelog * Increment Version to 0.9.1a2 --------- Co-authored-by: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Co-authored-by: JarbasAl <JarbasAl@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: miro <jarbasai@mailfence.com>
Summary by CodeRabbit