Skip to content

feat: add ovoscope end2end intent-routing tests#49

Draft
JarbasAl wants to merge 12 commits into
devfrom
feat/ovoscope-tests
Draft

feat: add ovoscope end2end intent-routing tests#49
JarbasAl wants to merge 12 commits into
devfrom
feat/ovoscope-tests

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jun 2, 2026

Copy link
Copy Markdown
Member

Auto-generated ovoscope intent-routing tests.

Covers Padatious intents (exact message-type assertions) and Adapt intents
(speak-response assertions). One test method per canonical utterance.

Generated by tools/gen_ovoscope_tests.py from the dataset at
knowledge/datasets/ovoscope/test_dataset.jsonl.

Run: pytest test/end2end/ -v --timeout=60

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b3570ea3-bb47-4f06-a383-4588baec4ecd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ovoscope-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Greetings! I've analyzed your changes and have some results to share. 🖖

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

Scanning for any signs of repository fatigue. 😫

✅ All required files present.

Latest Version: 1.1.0a1

skill_randomness/version.py — Version file
README.md — README
LICENSE — License file
⚠️ pyproject.toml — pyproject.toml
setup.py — setup.py
CHANGELOG.md — Changelog
requirements.txt — Requirements
skill_randomness/version.py has valid version block markers

🔍 Lint

Checking the boxes and crossing the T's. 🖋️

ruff: no issues

🎙️ Skill

Is the skill's voice clear and confident? Let's see. 🗣️

🎙️ (unknown skill_id) — 4 languages

en-US: 6 intents · 4 vocab · 11 dialogs · skill.json ⚠️

Translation coverage — 3 languages (3 complete)
Language Progress Coverage
eu-ES ██████████ ✅ 100.0% (21/21)
fr-FR ██████████ ✅ 100.0% (21/21)
gl-ES ██████████ ✅ 100.0% (21/21)

⚖️ License Check

Scanning for any hidden proprietary blobs. 🌑

✅ No license violations found (48 packages).

License distribution: 12× MIT License, 9× MIT, 6× Apache Software License, 5× Apache-2.0, 2× BSD-3-Clause, 2× ISC License (ISCL), 2× PSF-2.0, 2× Python Software Foundation License, +7 more

Full breakdown — 48 packages
Package Version License URL
audioop-lts 0.2.2 PSF-2.0 link
build 1.5.0 MIT link
certifi 2026.5.20 Mozilla Public License 2.0 (MPL 2.0) link
charset-normalizer 3.4.7 MIT link
click 8.4.1 BSD-3-Clause link
combo_lock 0.3.1 Apache-2.0 link
filelock 3.29.3 MIT link
idna 3.18 BSD-3-Clause link
importlib_metadata 9.0.0 Apache-2.0 link
json-database 0.10.1 MIT link
kthread 0.2.3 MIT License link
langcodes 3.5.1 MIT License link
markdown-it-py 4.2.0 MIT License link
mdurl 0.1.2 MIT License link
memory-tempfile 2.2.3 MIT License link
ovos-config 2.1.1 Apache-2.0 link
ovos-number-parser 0.5.1 Apache Software License link
ovos-plugin-manager 2.2.0 Apache-2.0 link
ovos-skill-randomness 1.1.0a1 MIT link
ovos-solver-yes-no-plugin 0.2.8 MIT link
ovos-utils 0.8.5 Apache-2.0 link
ovos_bus_client 1.5.0 Apache Software License link
ovos_workshop 8.0.0 apache-2.0 link
packaging 26.2 Apache-2.0 OR BSD-2-Clause link
padacioso 1.0.0 apache-2.0 link
pexpect 4.9.0 ISC License (ISCL) link
ptyprocess 0.7.0 ISC License (ISCL) link
pyee 12.1.1 MIT License link
Pygments 2.20.0 BSD-2-Clause link
pyproject_hooks 1.2.0 MIT License link
python-dateutil 2.9.0.post0 Apache Software License; BSD License link
PyYAML 6.0.3 MIT License link
quebra-frases 0.3.7 Apache Software License link
RapidFuzz 3.14.5 MIT link
regex 2026.5.9 Apache-2.0 AND CNRI-Python link
requests 2.34.2 Apache Software License link
rich 13.9.4 MIT License link
rich-click 1.9.8 MIT License

Copyright (c) 2022 Phil Ewels

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
| link |
| simplematch | 1.4 | MIT License | link |
| six | 1.17.0 | MIT License | link |
| standard-aifc | 3.13.0 | Python Software Foundation License | link |
| standard-chunk | 3.13.0 | Python Software Foundation License | link |
| typing_extensions | 4.15.0 | PSF-2.0 | link |
| unicode-rbnf | 2.4.0 | MIT License | |
| urllib3 | 2.7.0 | MIT | link |
| watchdog | 6.0.0 | Apache Software License | link |
| websocket-client | 1.9.0 | Apache Software License | link |
| zipp | 4.1.0 | MIT | link |

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🏷️ Release Preview

Ensuring the 'Contributors' list is sorted and complete. 👥

Current: 1.1.0a1Next: 1.2.0a1

Signal Value
Label feature
PR title feat: add ovoscope end2end intent-routing tests
Bump minor

✅ PR title follows conventional commit format.


🚀 Release Channel Compatibility

Predicted next version: 1.2.0a1

Channel Status Note Current Constraint
Stable Not in channel -
Testing Not in channel -
Alpha Not in channel -

🔒 Security (pip-audit)

Ensuring our project remains safe and secure. 🛡️

✅ No known vulnerabilities found (67 packages scanned).

🔨 Build Tests

Checking the alignment of our build components. 📏

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

❌ 3.10: Build OK, install failed
❌ 3.11: Build OK, install failed
❌ 3.12: Build OK, install failed
❌ 3.13: Build OK, install failed
❌ 3.14: Build OK, install failed
Check job logs for details.

📊 Coverage

Evaluating the thoroughness of our test suite. 🔎

⚠️ Coverage data unavailable — check the job log.

⚠️ Some tests failed — coverage figures may be incomplete.

🔌 Skill Tests (ovoscope)

Let's see how the skill performs under the microscope. 🔬

0/23 passed, 23 failed

❌ **TestPadatious1_Make_a_choice_intent** — 0/2
Test Result
test_help_me_decide_something ❌ failed
test_help_me_make_a_choice ❌ failed

test_help_me_decide_something failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_help_me_make_a_choice failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError
❌ **TestPadatious2_Pick_a_number_intent** — 0/5
Test Result
test_choose_a_number_between_one_and_one_hund ❌ failed
test_choose_a_number_between_something_and_so ❌ failed
test_pick_a_number_between_20_and_21 ❌ failed
test_pick_a_number_between_something_and_some ❌ failed
test_select_a_number_between_3_and_7 ❌ failed

test_choose_a_number_between_one_and_one_hund failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_choose_a_number_between_something_and_so failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_pick_a_number_between_20_and_21 failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError
❌ **TestPadatious3_Flip_a_coin_intent** — 0/1
Test Result
test_flip_a_coin ❌ failed

test_flip_a_coin failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError
❌ **TestPadatious4_Fortune_teller_intent** — 0/5
Test Result
test_tell_me_a_future ❌ failed
test_tell_me_fortune ❌ failed
test_tell_me_future ❌ failed
test_tell_me_my_fortune ❌ failed
test_tell_me_my_future ❌ failed

test_tell_me_a_future failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_tell_me_fortune failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_tell_me_future failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError
❌ **TestPadatious5_Roll_single_die_intent** — 0/5
Test Result
test_roll_a_20_sided_dice ❌ failed
test_roll_a_20_sided_die ❌ failed
test_roll_a_dice ❌ failed
test_roll_a_die ❌ failed
test_roll_die ❌ failed

test_roll_a_20_sided_dice failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_roll_a_20_sided_die failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_roll_a_dice failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError
❌ **TestPadatious6_Roll_multiple_dice_intent** — 0/5
Test Result
test_roll_6_20_sided_dice ❌ failed
test_roll_6_20_sided_die ❌ failed
test_roll_6_d_20 ❌ failed
test_roll_6_dice ❌ failed
test_roll_6_die ❌ failed

test_roll_6_20_sided_dice failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_roll_6_20_sided_die failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

test_roll_6_d_20 failure:

if expected.msg_type in self.flip_points:
                e_src = expected.context.get("source")
                e_dst = expected.context.get("destination")
    
            if self.test_msg_type:
>               assert expected.msg_type == received.msg_type, f"❌ expected message_type '{expected.msg_type}' | got '{received.msg_type}'"
E               AssertionError: ❌ expected message_type 'ovos-skill-randomness.openvoiceos.activate' | got 'complete_intent_failure'
E               assert 'ovos-skill-r...ceos.activate' == 'complete_intent_failure'
E                 
E                 - complete_intent_failure
E                 + ovos-skill-randomness.openvoiceos.activate

/opt/hostedtoolcache/Python/3.11.15/x64/lib/python3.11/site-packages/ovoscope/__init__.py:856: AssertionError

🚌 Bus Coverage

Scanning for any 'unasserted' emissions! 🚨

⚠️ Bus coverage report unavailable — check the job log.


The silent guardian of the dev branch. 🦇

JarbasAl and others added 11 commits June 10, 2026 19:32
…ious assertions

Suppresses speak/mycroft.audio.play_sound noise so message-count
checks are not thrown off by extra bus events; routing verified via activation_points.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Reconcile the unit-test assertions and skill.json skill_id with the
entry-point id declared in pyproject so e2e and unit tests agree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant