Skip to content

feat(homepage): resolves #174#189

Merged
SeleiXi merged 7 commits intoOpenTreeHole:mainfrom
ppolariss:division-refactor
Feb 14, 2026
Merged

feat(homepage): resolves #174#189
SeleiXi merged 7 commits intoOpenTreeHole:mainfrom
ppolariss:division-refactor

Conversation

@ppolariss
Copy link
Copy Markdown
Member

@ppolariss ppolariss commented Jul 29, 2025

resolves #174

@HydrogenC
Copy link
Copy Markdown

HydrogenC commented Sep 8, 2025

Since the new API /holes/_homepage is parallel to /holes, I would be better that they use the same parameter format.
I propose the following changes to keep the interface consistent between /holes/_homepage and /holes:

  • Rename param offset to start_time
  • Rename param size to length

Doing so would help simplify the client-code as we would only have to modify the URL.

@w568w
Copy link
Copy Markdown
Contributor

w568w commented Feb 14, 2026

Any progress?

@ppolariss ppolariss requested a review from SeleiXi February 14, 2026 13:52
Copy link
Copy Markdown
Member

@SeleiXi SeleiXi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeleiXi SeleiXi merged commit 8f7a8c6 into OpenTreeHole:main Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] 加一个大板块,集成所有包括了圆桌、茶楼、评教的帖子

4 participants