Add RenderBoxView and RBLayer integration #711
Conversation
🤖 Augment PR SummarySummary: This PR introduces RenderBox-backed drawing infrastructure and updates RenderBox integration points. Changes:
Technical Notes: The new RenderBox path is partially stubbed (several methods still call 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| self.options = options | ||
| super.init(frame: .zero) | ||
| isOpaque = options.isOpaque | ||
| layer.contentsFormat = options.caLayerContentsFormat |
There was a problem hiding this comment.
On macOS, NSView.layer can be nil unless the view is layer-backed (e.g. wantsLayer = true), so touching layer.contentsFormat (and later layer as! CGDrawingLayer) risks a crash if this view is constructed outside the platform view factory. (This same assumption about layer being present also applies to RenderBoxView.)
🤖 Was this useful? React with 👍 or 👎
|
|
||
| override func didMoveToWindow() { | ||
| guard let window else { return } | ||
| layer.contentsScale = window.screen.scale |
There was a problem hiding this comment.
window.screen isn’t guaranteed to be non-nil on macOS (and the scale API differs from UIKit), so window.screen.scale can be a crash/portability hazard; consider guarding/normalizing how the contents scale is derived per platform.
🤖 Was this useful? React with 👍 or 👎
No description provided.