Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 2, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 2, 2026

🤖 Augment PR Summary

Summary: Refactors Update.syncMain to better match the SwiftUI 6.5.4 synchronization behavior when hopping work onto the main thread.

Changes:

  • Replaces the previous @_silgen_name-based MovableLock.syncMain shim with a direct call to the imported MovableLock.syncMain(self:_:function:) entry point.
  • Packages the work closure plus relevant state into a small context struct and forwards it through the lock’s sync-main pathway.
  • Preserves and restores Subgraph.current around the main-thread execution to keep AttributeGraph state consistent across the thread hop.
  • Removes the now-unneeded MovableLock extension that declared the old external symbol.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye merged commit c7cd9cf into main Jan 2, 2026
7 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/update branch January 2, 2026 10:40
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.81%. Comparing base (4c855cf) to head (38209be).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Data/Update.swift 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   28.82%   28.81%   -0.02%     
==========================================
  Files         589      589              
  Lines       35780    35794      +14     
==========================================
  Hits        10314    10314              
- Misses      25466    25480      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants