-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Extend Swagger Coverage for controller OAuth2SummitAttendeesApiController
#437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Extend Swagger Coverage for controller OAuth2SummitAttendeesApiController
#437
Conversation
4500e70 to
567cc68
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close.
namespace App\Swagger\Security; should be namespace App\Swagger\schemas;
Should be good after that.
567cc68 to
d2b2d85
Compare
|
@matiasperrone-exo please review conflicts |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the updates, once conflicts are cleared this should be good.
c6ecdd0 to
728ae67
Compare
1aef61b to
d823c38
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the endpoint for:
#[OA\Post(
path: '/api/v1/summits/{id}/attendees/all/send',
...
Actually uses PUT
Route::put('send', ['middleware' => 'auth.user', 'uses' => 'OAuth2SummitAttendeesApiController@send']);
api_v1.php line 1597
Route::put('send', ...)
ApiEndpointsSeeder.php line 3374:
'http_method' => 'PUT'
Change OA\Post to OA\Put for
#[OA\Post(
path: '/api/v1/summits/{id}/attendees/all/send',
operationId: 'sendAttendeesEmail',
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Task:
Ref: https://app.clickup.com/t/86b6wkhca