Add support for enabling PWS with local persistence#150
Open
ruimarinho wants to merge 1 commit intoOpenSprinkler:masterfrom
Open
Add support for enabling PWS with local persistence#150ruimarinho wants to merge 1 commit intoOpenSprinkler:masterfrom
ruimarinho wants to merge 1 commit intoOpenSprinkler:masterfrom
Conversation
|
@rayshobby we should review if this can be closed/integrated when the recent weather related changes are complete cc @Ncp294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a
PWS(Personal Weather Station) is configured (currently, only theWUtype is recognized by the code), OpenSprinkler-Weather will automatically register the route/weatherstation/updateweatherstation.phpto capture the WU data stream.However, it only saves changes from the captured stream if the
WEATHER_PROVIDERis set tolocal. In my opinion, this is too restrictive, as one might want to collect observations before switching to the local weather provider.Therefore, I suggest testing for the presence of the
PWSvariable instead, allowing the capturing system to function fully without requiring a provider switch.