Skip to content

Fix remove inappropriate roles menu and menuitem #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stef-Rousset wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Fix remove inappropriate roles menu and menuitem #1281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
25d5fe8
fix: remove inappropriate roles menu and menuitem
Stef-Rousset Jun 18, 2025
97c5a23
fix: accessibility on ul menu on account page
Stef-Rousset Jul 9, 2025
552d491
fix: remove unwanted code
Stef-Rousset Jul 10, 2025
2d1be5b
fix: add js again to fix account page accessibility
Stef-Rousset Jul 28, 2025
fafe912
fix: remove js added for account page accessibility
Stef-Rousset Sep 1, 2025
c0ad771
test: try fixing election system test
Stef-Rousset Sep 1, 2025
2ed2bbc
style: update test with rubocop
Stef-Rousset Sep 1, 2025
a35b0e5
Trigger CI
Stef-Rousset Sep 2, 2025
cab914f
revert: modification of elections test
Stef-Rousset Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion decidim-core/app/helpers/decidim/menu_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def footer_menu
self,
element_class: "font-semibold underline",
active_class: "is-active",
container_options: { class: "space-y-4 break-inside-avoid", role: :menu },
container_options: { class: "space-y-4 break-inside-avoid" },
label: t("layouts.decidim.footer.decidim_title")
)
end
Expand Down
2 changes: 1 addition & 1 deletion decidim-core/app/presenters/decidim/menu_item_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def initialize(menu_item, view, options = {})
delegate :content_tag, :safe_join, :link_to, :active_link_to_class, :is_active_link?, :icon, to: :@view

def render
content_tag :li, role: :menuitem, class: link_wrapper_classes do
content_tag :li, class: link_wrapper_classes do
output = if url == "#"
[content_tag(:span, composed_label, class: "sidebar-menu__item-disabled")]
else
Expand Down
Loading