Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
1c65f45
Support runtime-supplied points on continuous-action IrregSpacedGrids
hmgaudecker Apr 29, 2026
1792279
benchmarks: bump aca-model to runtime-consumption-points version
hmgaudecker Apr 29, 2026
cf00e99
Fail loudly when reading runtime IrregSpacedGrid before substitution
hmgaudecker Apr 29, 2026
db98cde
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 29, 2026
03ba800
Fix remaining ruff check errors in test_single_feasible_action.py
hmgaudecker Apr 29, 2026
3769d2d
Raise on regime-function-output indexed by discrete state in a consumer
hmgaudecker Apr 29, 2026
282542f
benchmarks: bump aca-model to dead-regime-NaN fix
hmgaudecker Apr 29, 2026
72c83f7
Substitute runtime-supplied action gridpoints in simulate's state-act…
hmgaudecker Apr 29, 2026
db6214f
Guard log-spaced grids against non-positive start; reject non-finite …
hmgaudecker Apr 30, 2026
f56b9be
Address PR review: docstrings, type hints, validation, drop separator…
hmgaudecker Apr 30, 2026
3b7be82
LogSpacedGrid docstring: drop redundant rationale
hmgaudecker May 1, 2026
8589146
IrregSpacedGrid.to_jax docstring: shorter, point at the substituted-g…
hmgaudecker May 1, 2026
541392c
IrregSpacedGrid.to_jax error message: same shape as docstring
hmgaudecker May 1, 2026
54d22b0
Use jnp.isfinite in grid validators; drop math import
hmgaudecker May 1, 2026
ba38876
Drop cryptic aca_model reference from validator docstring
hmgaudecker May 1, 2026
4d11dea
Validator: also flag function-output indexed by a derived categorical
hmgaudecker May 1, 2026
01608bb
create_regime_state_action_space docstring: trim rationale
hmgaudecker May 1, 2026
6241056
state_action_space: move private helpers below public function (deep …
hmgaudecker May 1, 2026
2efe9e1
Drop application-specific (aca) references from test docstrings
hmgaudecker May 1, 2026
f1c4d5d
Validator: rename to discrete_grid_names, also include discrete actions
hmgaudecker May 1, 2026
d9f37ce
Validator: tighten to actual footgun shape; correct behaviour descrip…
hmgaudecker May 1, 2026
2cc46ff
solve_brute: stream NaN/Inf reductions instead of stacking-and-flushing
hmgaudecker May 1, 2026
365da07
solve_brute: stop pinning per-period V templates in diagnostic_rows
hmgaudecker May 1, 2026
bf1cdf4
solve_brute: fail-fast on NaN per period; rewrite stale diagnostic hint
hmgaudecker May 4, 2026
c7745f3
solve/simulate: surface snapshot path in NaN exception note
hmgaudecker May 4, 2026
a51edae
regime_template: exempt next_<state> names from fixed_param extraction
hmgaudecker May 4, 2026
71a6146
Merge feature/next-state-deps-in-transitions: exempt next_<state> fro…
hmgaudecker May 4, 2026
d66d85a
Boilerplate refresh: dags module, current pixi/hook pins, drop stale …
hmgaudecker May 4, 2026
f18d27c
Bump .ai-instructions: pyproject-fmt + ruff + check-jsonschema rev pins
hmgaudecker May 4, 2026
5e01de6
Merge feature/runtime-action-grids: boilerplate refresh + ai-instruct…
hmgaudecker May 4, 2026
f730e78
Merge feature/next-state-deps-in-transitions: boilerplate refresh + a…
hmgaudecker May 4, 2026
c3e1838
Merge main: pick up #338 (runtime action grids + validator tightening)
hmgaudecker May 4, 2026
01ba1f3
Merge feature/next-state-deps-in-transitions (carries main → #338)
hmgaudecker May 4, 2026
e45cf4f
regime_template: reject next_<state> params on regular DAG functions
hmgaudecker May 4, 2026
5ff174d
Merge feature/next-state-deps-in-transitions: harden next_<state> val…
hmgaudecker May 4, 2026
c585f4b
Bump aca-model benchmark pin to 83f22500 (post pension correction)
hmgaudecker May 4, 2026
ffe8820
Merge feature/next-state-deps-in-transitions: bump aca-model benchmar…
hmgaudecker May 4, 2026
f0dd7b5
Revert aca-model pin: this branch lacks Model.n_subjects (introduced …
hmgaudecker May 4, 2026
149ac78
Merge feature/next-state-deps-in-transitions: revert aca-model pin to…
hmgaudecker May 4, 2026
e89d5e4
Revert "regime_template: reject next_<state> params on regular DAG fu…
hmgaudecker May 4, 2026
d07d897
Merge feature/next-state-deps-in-transitions: revert validator that c…
hmgaudecker May 4, 2026
6c64a77
get_next_state_function_for_simulation: per-target DAG mirrors solve
hmgaudecker May 5, 2026
fed28cd
Merge feature/next-state-deps-in-transitions: pull pylcm simulate-pat…
hmgaudecker May 5, 2026
8a2ad4f
Address #342 review: simulate-path uses concatenate_functions; cleanups
hmgaudecker May 6, 2026
bcdd358
Merge feature/next-state-deps-in-transitions: address #342 review fee…
hmgaudecker May 6, 2026
17347c8
Get rid of H_variables entirely in regime_template.
hmgaudecker May 6, 2026
076b9b6
Bump .ai-instructions: TDD always; behavior-focused docstrings
hmgaudecker May 6, 2026
e6f8e41
Merge feature/next-state-deps-in-transitions: bump .ai-instructions f…
hmgaudecker May 6, 2026
164a88b
AGENTS.md: inline TDD-always testing section directly
hmgaudecker May 6, 2026
07c5ae0
Merge feature/next-state-deps-in-transitions: inline TDD section in A…
hmgaudecker May 6, 2026
5261e29
Address #339 review: drop field-count test; tighten claudish docstrings
hmgaudecker May 6, 2026
110cc0b
regime_template: collapse H_variables into single variables set
hmgaudecker May 6, 2026
4b2895c
Merge feature/next-state-deps-in-transitions: collapse H_variables
hmgaudecker May 6, 2026
a7b9e9a
solve_brute: drop misleading "~2 MB each" magic number from comment
hmgaudecker May 6, 2026
16b570f
AGENTS.md: docstring style — describe state, no PR refs, bulleted lists
hmgaudecker May 6, 2026
1251f0b
Merge feature/next-state-deps-in-transitions: docstring style + .ai-i…
hmgaudecker May 6, 2026
ff65261
solve_brute: apply docstring style — drop PR ref, magic number; bulle…
hmgaudecker May 6, 2026
eb69432
Merge main: pick up squash of #342
hmgaudecker May 6, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/lcm/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,13 +221,14 @@ def solve(
)
except InvalidValueFunctionError as exc:
if log_path is not None and exc.partial_solution is not None:
save_solve_snapshot(
snap_dir = save_solve_snapshot(
model=self,
params=params,
period_to_regime_to_V_arr=exc.partial_solution, # ty: ignore[invalid-argument-type]
log_path=Path(log_path),
log_keep_n_latest=log_keep_n_latest,
)
exc.add_note(f"Snapshot saved to {snap_dir}")
raise
if log_level == "debug" and log_path is not None:
save_solve_snapshot(
Expand Down Expand Up @@ -331,13 +332,14 @@ def simulate(
)
except InvalidValueFunctionError as exc:
if log_path is not None and exc.partial_solution is not None:
save_solve_snapshot(
snap_dir = save_solve_snapshot(
model=self,
params=params,
period_to_regime_to_V_arr=exc.partial_solution, # ty: ignore[invalid-argument-type]
log_path=Path(log_path),
log_keep_n_latest=log_keep_n_latest,
)
exc.add_note(f"Snapshot saved to {snap_dir}")
raise
result = simulate(
internal_params=internal_params,
Expand Down
Loading
Loading