Fix CRs for paragraphs with empty first line#5340
Merged
bastianjoel merged 47 commits intoOpenSlides:mainfrom Apr 27, 2026
Merged
Fix CRs for paragraphs with empty first line#5340bastianjoel merged 47 commits intoOpenSlides:mainfrom
bastianjoel merged 47 commits intoOpenSlides:mainfrom
Conversation
bastianjoel
changed the title
3 tasks
Elblinator
added
the
waiting
Member
|
Do not merge yet |
Elblinator
approved these changes
Aug 27, 2025
Member
|
Please reassign me if approved |
luisa-beerboom
approved these changes
Aug 28, 2025
bastianjoel
force-pushed
the
5165-fix-empty-br
branch
4 times, most recently
from
ed0db4d to
22867e2
Compare
luisa-beerboom
approved these changes
Mar 26, 2026
m-schieder
force-pushed
the
5165-fix-empty-br
branch
2 times, most recently
from
70587a7 to
29ed38d
Compare
MSoeb
requested changes
Apr 23, 2026
MSoeb
left a comment
MSoeb
left a comment
There was a problem hiding this comment.
Existing motions that contain blank lines without line numbers will be assigned line numbers when the PR is applied. This results in incorrect line numbers in existing motions.
This should not happen.
I’ve discussed this with Bastian and Raimund.
MSoeb
approved these changes
Apr 27, 2026
There was a problem hiding this comment.
Missing line value is fixed. No new line numbering will be added.
Info: The height gap between two paragraphs in this case is equal to the one which will be added in new motions by hitting enter two times. If this will be relevant, we have the option to change it at a later point. For now the problems are fixed and the line numbers are consinstent. So we can go on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #5164
resolves #5165
resolves #5355
reoslves potentionally OpenSlides/OpenSlides#6927
Needs:
autoupdate in main
backend in main