[DRAFT] Begin cleaning up the script implementation#67
Draft
zontreck wants to merge 4 commits intoOpenSim-NGC:dev-futurefrom
Draft
[DRAFT] Begin cleaning up the script implementation#67zontreck wants to merge 4 commits intoOpenSim-NGC:dev-futurefrom
zontreck wants to merge 4 commits intoOpenSim-NGC:dev-futurefrom
Conversation
…eading, and sanity.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is both a refactoring change and a proposal on structure. The change made is simply splitting up a 18k line file into several different files, grouping the functions together. This is accomplished by using a Partial class.
This will not be limited to LSL, but it is the primary focus right now as that file is very difficult to edit at this time.