Add two LSL Functions requested by #52#66
Open
zontreck wants to merge 12 commits intoOpenSim-NGC:dev-futurefrom
Open
Add two LSL Functions requested by #52#66zontreck wants to merge 12 commits intoOpenSim-NGC:dev-futurefrom
zontreck wants to merge 12 commits intoOpenSim-NGC:dev-futurefrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
4714
to
4726
| foreach (var sog in sogs) | ||
| { | ||
| if (sog is SceneObjectGroup sogx) | ||
| { | ||
|
|
||
| // If owner of SOG is [owner], return it. | ||
| if (sogx.OwnerID.ToString() == owner) | ||
| { | ||
| count++; | ||
| World.AddReturn(sogx.GroupID, sogx.Name, sogx.AbsolutePosition, "Object Owner Return"); | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
Comment on lines
4730
to
4747
| foreach (var iParcel in parcels) | ||
| { | ||
| if (iParcel.OwnerID == m_host.OwnerID || IsEstateOwnerOrManager(m_host.OwnerID)) | ||
| { | ||
| var sogs = iParcel.GetSceneObjectGroups(); | ||
| foreach (var isog in sogs) | ||
| { | ||
| if (isog is SceneObjectGroup sog) | ||
| { | ||
| if (sog.OwnerID.ToString() == owner) | ||
| { | ||
| count++; | ||
| World.AddReturn(sog.GroupID, sog.Name, sog.AbsolutePosition, "Object Owner Return"); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
| } | ||
| } | ||
| } | ||
| catch (Exception e) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
Comment on lines
+4707
to
+4715
| foreach (SceneObjectGroup sog in World.GetSceneObjectGroups()) | ||
| { | ||
| if (sog.OwnerID.ToString() == owner && !IsEstateOwnerOrManager(sog.OwnerID)) | ||
| { | ||
| count++; | ||
| lSogs.Add(sog); | ||
|
|
||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
Comment on lines
+4740
to
+4750
| foreach (var isog in sogs) | ||
| { | ||
| if (isog is SceneObjectGroup sog) | ||
| { | ||
| if (sog.OwnerID.ToString() == owner && !IsEstateOwnerOrManager(sog.OwnerID)) | ||
| { | ||
| count++; | ||
| lSogs.Add(sog); | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
zontreck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by #52, this PR aims to add two new functions: llReturnObjectsByID and llReturnObjectsByOwner.