feat: .NET 10 #51
feat: .NET 10 #51
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project from .NET 9 to .NET 10, updating the target framework, SDK version, package references, and Docker images. Additionally, it includes code cleanup by removing unused imports, adjusting a namespace, and simplifying some API calls.
- Updated target framework from
net9.0tonet10.0across all projects - Updated Microsoft package references from version 9.0.x to 10.0.0
- Removed unused imports and cleaned up code quality issues
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Specifies .NET SDK 10.0.0 as the project SDK version |
| MigrationHelper/MigrationHelper.csproj | Updates target framework and EF Core packages to version 10.0 |
| Dockerfile | Updates base images to .NET 10.0 SDK and runtime |
| DiscordBot/Utils/Embeds.cs | Removes unused imports |
| DiscordBot/Utils/DiscordUtils.cs | Removes unused import |
| DiscordBot/Utils/ApiUtils.cs | Removes unused import |
| DiscordBot/Services/OpenShockBackendService.cs | Removes unused imports |
| DiscordBot/Services/InteractionHandler.cs | Removes unused import |
| DiscordBot/Program.cs | Removes unused import and adds new namespace import |
| DiscordBot/OpenShockDiscordDb/*.cs | Removes unused System namespace imports |
| DiscordBot/MessageHandler/MessageHandler.cs | Updates namespace and modifies Task.WhenAll syntax |
| DiscordBot/DiscordBot.csproj | Updates target framework, removes LangVersion, updates all package references to version 10.0 |
| DiscordBot/Commands/Setup/SetupConnectionCommand.cs | Removes generic type parameter from RespondWithModalAsync call |
| DiscordBot/Commands/ProfanityAdmin/*.cs | Removes unused imports |
| DiscordBot/Commands/Profanity/ProfanityListCommand.cs | Simplifies Queryable method call by removing explicit type parameters |
| DiscordBot/Commands/ControlCommands.cs | Removes unused import |
| DiscordBot/Commands/Admin/AdminListCommand.cs | Removes unused import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ApiServer = user.ApiServer | ||
| }; | ||
| await Context.Interaction.RespondWithModalAsync<SetupModal>(SetupModalId, previousData); | ||
| await Context.Interaction.RespondWithModalAsync(SetupModalId, previousData); |
There was a problem hiding this comment.
The generic type parameter was removed from RespondWithModalAsync, but line 23 in the same file still uses RespondWithModalAsync<SetupModal>. This inconsistency suggests either: 1) line 23 should also be updated to remove the generic parameter, or 2) this change may be incorrect. Please ensure both calls use the same API pattern.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.