Fix/dotnet 10 openapi 2 #264
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe we should just exclude the deprecated endpoint from api docs completely, and maybe do so with every v2 api that is meant to replace a v1 api, not sure 🤔 |
Contributor
Author
There was only that one endpoint that was messing up the ts-client generate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to fix some issues with v1 endpoints using
"[]"or"`1"in name. Also needed to break apart1/devices/pair/{pairId}because it was getting the same operationIdI'm able to generate with no errors off localhost. There are still some minor differences with v1 nullability, using
Bytesome places instead of number, and moving things around inside generated files. But overall seems to be pretty close.Not sure why branching off has that duplicated commit. Maybe because It was draft / not directly merged? idk