Skip to content

Conversation

@TuTiDore
Copy link
Contributor

@TuTiDore TuTiDore commented Dec 21, 2025

Add new V1 endpoint for getting logs from all shockers. Enables fronted to not use N fetch.

screenshot-2025-12-21_14-44-15

@hhvrc
Copy link
Contributor

hhvrc commented Dec 21, 2025

I would not make this a V2 endpoint since it doesnt serve the same purpose as the V1 logs endpoint.
Just have {shockerId}/logs and /logs both as V1

@hhvrc
Copy link
Contributor

hhvrc commented Dec 21, 2025

also for any new implementation we try to use the word "hub" instead of "device" when talking about the OpenShock hubs

@hhvrc hhvrc added the enhancement New feature or request label Dec 21, 2025
@hhvrc hhvrc added this to Roadmap Dec 21, 2025
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Dec 21, 2025
@hhvrc hhvrc moved this from Todo to In Progress in Roadmap Dec 21, 2025
@TuTiDore
Copy link
Contributor Author

I would not make this a V2 endpoint since it doesnt serve the same purpose as the V1 logs endpoint. Just have {shockerId}/logs and /logs both as V1

Ok, I thought V1 would remain for webui and new endpoints would be V2 so there's no breaking changes for V1. I will update this PR.

@LucHeart
Copy link
Member

I would not make this a V2 endpoint since it doesnt serve the same purpose as the V1 logs endpoint. Just have {shockerId}/logs and /logs both as V1

Ok, I thought V1 would remain for webui and new endpoints would be V2 so there's no breaking changes for V1. I will update this PR.

so our versioning is pretty flat, only when we need to actually reuse a endpoint path, we make a v2 as of now

@TuTiDore TuTiDore changed the title feat: add v2 endpoint /shockers/logs feat: add v1 endpoint /shockers/logs Dec 21, 2025
@TuTiDore TuTiDore requested a review from LucHeart December 21, 2025 22:04
@TuTiDore TuTiDore requested a review from hhvrc December 21, 2025 22:51
Copy link
Contributor

@hhvrc hhvrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucHeart LucHeart merged commit acd0de6 into OpenShock:develop Dec 21, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants