-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add v1 endpoint /shockers/logs #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would not make this a V2 endpoint since it doesnt serve the same purpose as the V1 logs endpoint. |
|
also for any new implementation we try to use the word "hub" instead of "device" when talking about the OpenShock hubs |
Ok, I thought V1 would remain for webui and new endpoints would be V2 so there's no breaking changes for V1. I will update this PR. |
so our versioning is pretty flat, only when we need to actually reuse a endpoint path, we make a v2 as of now |
hhvrc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add new V1 endpoint for getting logs from all shockers. Enables fronted to not use N fetch.