Draft
Conversation
- Combine ChangeOversampling + LoadPreset into single background task to fix ordering race where preset could load at wrong sample rate - Split into requested/active oversampling atomics so chain rebuilds match actual sampler state (fixes GUI rebuild-before-samplers race) - Persist oversampling changes to settings in standalone mode - Notify DAW host when oversampling changes (marks session dirty) - Remove dead SettingsMessage::OversamplingFactorChanged variant - Add debug_assert for power-of-two validation on oversampling factor - Replace oversampling_exp (exponent) with oversampling_factor (direct) throughout plugin, matching standalone and UI conventions
- Change persist key from "oversampling" to "oversampling_factor" to avoid silent misinterpretation of legacy project data - Rebuild chain from gui_stages (in-session edits) instead of reloading from disk preset, which would wipe user stage modifications - Normalize persisted oversampling factor to nearest valid power-of-two on restore (handles corrupted/legacy values)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.