Add db.isNullable and db.nativeType support to all field types#353
Merged
Add db.isNullable and db.nativeType support to all field types#353
Conversation
Restores Keystone 6 db field-level config options that were missing from OpenSaaS Stack, allowing independent control of DB-level nullability and native database type overrides across all field types. - Add isNullable and nativeType to BaseFieldConfig.db (inherited by all fields) - Update integer(), password(), json(), timestamp(), checkbox() to handle db.isNullable (overrides validation.isRequired for DB nullability) - Update integer(), password(), json(), timestamp() to handle db.nativeType (generates @db.<type> attribute in Prisma schema) - text() already had support; simplify TextField.db (options now inherited) - Simplify DecimalField.db and CalendarDayField.db (isNullable now inherited) - Apply trimStart() consistently in getPrismaType returns for clean modifiers - Add comprehensive tests covering all new db config combinations Fixes #351 https://claude.ai/code/session_01LwV5V9az64n5xQr6gVKtuZ
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 87158dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
After adding trimStart() to getPrismaType() in the core package, the CLI's Prisma schema generator was concatenating type and modifiers without proper spacing. The '?' nullability marker must attach directly to the type while other modifiers (@Map, @default, @db.*) need a space separator. https://claude.ai/code/session_01LwV5V9az64n5xQr6gVKtuZ
Contributor
Coverage Report for Core Package Coverage (./packages/core)
File CoverageNo changed files found. |
Contributor
Coverage Report for UI Package Coverage (./packages/ui)
File CoverageNo changed files found. |
Contributor
Coverage Report for CLI Package Coverage (./packages/cli)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
Coverage Report for Auth Package Coverage (./packages/auth)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage Package Coverage (./packages/storage)
File CoverageNo changed files found. |
Contributor
Coverage Report for RAG Package Coverage (./packages/rag)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage S3 Package Coverage (./packages/storage-s3)
File CoverageNo changed files found. |
Contributor
Coverage Report for Storage Vercel Package Coverage (./packages/storage-vercel)
File CoverageNo changed files found. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #351
Summary
This PR extends database configuration options to all field types by moving
db.isNullableanddb.nativeTypefrom field-specific definitions to the sharedBaseFieldConfig. This allows consistent control over database-level nullability and native column types across all field types.Key Changes
Unified DB configuration: Moved
isNullableandnativeTypefromTextFieldtoBaseFieldConfig, making them available on all field types (text,integer,password,json,timestamp,checkbox,decimal,calendarDay)Nullability logic refactored: Updated
getPrismaType()implementations across all field types to:db.isNullablewhen providedvalidation.isRequiredwhen not specifiedtimestampwith@default(now())is non-nullable by default)Native type support: Added
@db.<nativeType>attribute generation to field types that previously lacked it (integer,password,json,timestamp,checkbox)Modifier string handling: Fixed modifier string generation across all field types by:
.trimStart()to clean up leading whitespace before returning? @db.Text)undefinedinstead of empty strings for fields with no modifiersComprehensive test coverage: Added 30+ new test cases covering:
db.isNullable: true/falsebehavior on all field typesisNullableandvalidation.isRequireddb.nativeTypegeneration with various field configurationsImplementation Details
The nullability logic now follows this precedence:
db.isNullableis explicitly set, use that valuevalidation.isRequired(required = non-nullable, optional = nullable)timestampfields with@default(now())are non-nullable by defaultThis allows developers to:
https://claude.ai/code/session_01LwV5V9az64n5xQr6gVKtuZ