fixed complaints in php8 (manual testing in 8.2.15)#57
Open
bcash wants to merge 1 commit intoOpenSRS:masterfrom
Open
fixed complaints in php8 (manual testing in 8.2.15)#57bcash wants to merge 1 commit intoOpenSRS:masterfrom
bcash wants to merge 1 commit intoOpenSRS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some minor modifications to allow this code to run in php8. only minor manual testing with domain lookups so far, but these changes are pretty low impact. I'd love to stop pulling from my own fork and get back on the official opensrs train. thanks!