Skip to content

fix(spp_change_request_v2): fix batch approval wizard line deletion #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emjay0921 wants to merge 3 commits into
base: 19.0
Choose a base branch
from

test(spp_change_request_v2): split batch tests to avoid skipTest

2c97d72
Select commit
Loading
Failed to load commit list.
Open

fix(spp_change_request_v2): fix batch approval wizard line deletion #130

test(spp_change_request_v2): split batch tests to avoid skipTest
2c97d72
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 23, 2026 in 0s

70.01% (+0.04%) compared to a8efe28

View this Pull Request on Codecov

70.01% (+0.04%) compared to a8efe28

Details

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.01%. Comparing base (a8efe28) to head (2c97d72).
⚠️ Report is 1 commits behind head on 19.0.

Files with missing lines Patch % Lines
...change_request_v2/wizards/batch_approval_wizard.py 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0     #130      +/-   ##
==========================================
+ Coverage   69.96%   70.01%   +0.04%     
==========================================
  Files         832      835       +3     
  Lines       48813    49139     +326     
==========================================
+ Hits        34154    34406     +252     
- Misses      14659    14733      +74
Files with missing lines Coverage Δ
...change_request_v2/wizards/batch_approval_wizard.py 49.21% <93.75%> (+16.14%) ⬆️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov