Skip to content

fix(spp_change_request_v2): remove global keyboard hotkeys #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emjay0921 merged 2 commits into from
Mar 19, 2026
Merged

fix(spp_change_request_v2): remove global keyboard hotkeys #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c996f
fix(spp_change_request_v2): remove global keyboard hotkeys
emjay0921 Mar 19, 2026
ea29f95
fix: remove extra blank line (prettier)
emjay0921 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
163 changes: 0 additions & 163 deletions spp_change_request_v2/static/src/components/global_shortcuts/global_shortcuts.js
View file
Open in desktop

This file was deleted.

56 changes: 1 addition & 55 deletions spp_change_request_v2/static/src/components/review_panel/review_panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/** @odoo-module **/

import {Component, onMounted, onWillUnmount, useRef, useState} from "@odoo/owl";
import {Component, onMounted, useRef, useState} from "@odoo/owl";
import {useService} from "@web/core/utils/hooks";
import {_t} from "@web/core/l10n/translation";

Expand All @@ -10,14 +10,6 @@ import {_t} from "@web/core/l10n/translation";
* Provides a side-by-side view of:
* - Left: Current registrant data
* - Right: Proposed changes
*
* Keyboard shortcuts:
* - A: Approve
* - R: Request changes
* - D: Decline
* - N: Next in queue
* - P: Previous in queue
* - Escape: Close panel
*/
export class CRReviewPanel extends Component {
static template = "spp_change_request_v2.CRReviewPanel";
Expand Down Expand Up @@ -54,11 +46,6 @@ export class CRReviewPanel extends Component {

onMounted(() => {
this.loadData();
document.addEventListener("keydown", this.onKeydown.bind(this));
});

onWillUnmount(() => {
document.removeEventListener("keydown", this.onKeydown.bind(this));
});
}

Expand Down Expand Up @@ -163,47 +150,6 @@ export class CRReviewPanel extends Component {
}
}

// Keyboard handler
onKeydown(event) {
// Don't handle if we're in an input
if (event.target.tagName === "INPUT" || event.target.tagName === "TEXTAREA") {
return;
}

switch (event.key.toLowerCase()) {
case "a":
if (this.state.canApprove) {
event.preventDefault();
this.onApprove();
}
break;
case "r":
if (this.state.canReject) {
event.preventDefault();
this.onRequestChanges();
}
break;
case "d":
if (this.state.canReject) {
event.preventDefault();
this.onDecline();
}
break;
case "n":
event.preventDefault();
this.onNext();
break;
case "p":
event.preventDefault();
this.onPrevious();
break;
case "escape":
event.preventDefault();
this.onClose();
break;
}
}

// Action handlers
async onApprove() {
if (this.state.showApproveComment) {
Expand Down
Loading