Skip to content

drouting: fix random GW selection when all weights are zero #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wlp2s0 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

drouting: fix random GW selection when all weights are zero #3867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/drouting/drouting.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2997,9 +2997,9 @@ static int weight_based_sort(pgw_list_t *pgwl, int size, unsigned short *idx)
// return -1;
}
} else {
/* randomly select index */
// i = (unsigned int)((size-first)*((double)rand()/((double)RAND_MAX)));
i = first;
/* all remaining gateways have weight 0, treat them as equal
and randomly select one with uniform distribution */
i = first + (unsigned int)((size - first) * ((double)rand() / ((double)RAND_MAX + 1.0)));
}
LM_DBG("selecting element %d with weight %d\n",
idx[i], pgwl[ idx[i] ].weight);
Expand Down