Skip to content

EDDSA: Add public key resolution with certificate fallback and extend test coverage#644

Merged
mtrojnar merged 4 commits intoOpenSC:masterfrom
olszomal:eddsa
Mar 17, 2026
Merged

EDDSA: Add public key resolution with certificate fallback and extend test coverage#644
mtrojnar merged 4 commits intoOpenSC:masterfrom
olszomal:eddsa

Conversation

@olszomal
Copy link
Collaborator

Pull Request Type

  • Bug fix
  • New feature
  • Code style / formatting / renaming
  • Refactoring (no functional or API changes)
  • Build / CI related changes
  • Documentation
  • Other (please describe):

Related Issue

Issue number: N/A

Current Behavior

  • EdDSA tests were incomplete.
  • Public key extraction relied on CKO_PUBLIC_KEY only.
  • No fallback to CKO_CERTIFICATE.
  • Minor test and initialization inconsistencies.

New Behavior

  • Public key is resolved in order:
  1. CKO_PUBLIC_KEY (CKA_EC_POINT)
  2. CKO_CERTIFICATE (DER X.509 parsing)
  • Added Ed25519/Ed448 provider tests covering both paths.
  • Improved internal handling and test correctness.

Scope of Changes

  • EDDSA public key resolution logic
  • New Ed25519/Ed448 provider tests
  • Test fixes and minor internal cleanup

Testing

  • Existing tests
  • New tests added
  • Manual testing

Additional Notes

License Declaration

  • I hereby agree to license my contribution under the project's license.

@mtrojnar mtrojnar merged commit 1894035 into OpenSC:master Mar 17, 2026
10 checks passed
@olszomal olszomal deleted the eddsa branch March 19, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants