Skip to content

conf.c: Fix stopping scheduler on unknown directive #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zdohnal merged 1 commit into from
Dec 4, 2025
+7 −7
Merged

conf.c: Fix stopping scheduler on unknown directive #1443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions scheduler/conf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2772,16 +2772,16 @@ parse_variable(
{
/*
* Unknown directive! Output an error message and continue...
*
* Return value 1 is on purpose - we ignore unknown directives to log
* error, but do not stop the scheduler in case error in configuration
* is set to be fatal.
*/

if (!value)
cupsdLogMessage(CUPSD_LOG_ERROR, "Missing value for %s on line %d of %s.",
line, linenum, filename);
else
cupsdLogMessage(CUPSD_LOG_ERROR, "Unknown directive %s on line %d of %s.",
line, linenum, filename);
cupsdLogMessage(CUPSD_LOG_ERROR, "Unknown directive %s on line %d of %s.",
line, linenum, filename);

return (0);
return (1);
}

switch (var->type)
Expand Down
Loading