fix S3 presign URI for checkpoint archive deployment#653
Open
yu2001-s wants to merge 1 commit intoOpenPipe:mainfrom
Open
fix S3 presign URI for checkpoint archive deployment#653yu2001-s wants to merge 1 commit intoOpenPipe:mainfrom
yu2001-s wants to merge 1 commit intoOpenPipe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s3://...URI toaws s3 presignwhen archiving checkpoint stepsRoot cause
archive_and_presign_step_url()stripped thes3://prefix before invokingaws s3 presign. The AWS CLI expects an S3 URI there, so Together deployment flows could fail after a successful archive upload because the presign command was handed an invalid path.Validation
uv run pytest tests/unit/test_s3_utils.py -quv run ruff check src/art/utils/s3.py tests/unit/test_s3_utils.pyuv run --with safetensors ty check src/art/utils/s3.py tests/unit/test_s3_utils.pyNotes
uv run pytest --nbval --current-env --tb=short tests/unit -qis not runnable in this default local environment because several existing unit-test modules require optional heavy deps (torch,transformers,datasets) that are not installed.