Skip to content

feat: Add dedicated lora mode to Megatron backend #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivekkalyan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add dedicated lora mode to Megatron backend #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/art/megatron/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import os

from mp_actors import move_to_child_process

from ..local.backend import LocalBackend
Expand All @@ -19,6 +21,7 @@ def __init__(

async def _get_service(self, model: TrainableModel) -> ModelService:
from ..dev.get_model_config import get_model_config
from ..dev.validate import is_dedicated_mode, validate_dedicated_config
from .service import MegatronService

if model.name not in self._services:
Expand All @@ -27,13 +30,19 @@ async def _get_service(self, model: TrainableModel) -> ModelService:
output_dir=get_model_dir(model=model, art_path=self._path),
config=model._internal_config,
)
validate_dedicated_config(config)
dedicated = is_dedicated_mode(config)
if dedicated:
os.environ["CUDA_VISIBLE_DEVICES"] = ",".join(
str(gpu_id) for gpu_id in config["trainer_gpu_ids"]
)
self._services[model.name] = MegatronService(
model_name=model.name,
base_model=model.base_model,
config=config,
output_dir=get_model_dir(model=model, art_path=self._path),
)
if not self._in_process:
if not dedicated and not self._in_process:
self._services[model.name] = move_to_child_process(
self._services[model.name],
process_name="megatron-service",
Expand Down
Loading
Loading