Skip to content

Open PROT changes to pldm-lib.#2

Merged
CourtneyDrant merged 2 commits into
OpenPRoT:mainfrom
CourtneyDrant:openprot
Jan 6, 2026
Merged

Open PROT changes to pldm-lib.#2
CourtneyDrant merged 2 commits into
OpenPRoT:mainfrom
CourtneyDrant:openprot

Conversation

@CourtneyDrant
Copy link
Copy Markdown
Collaborator

@CourtneyDrant CourtneyDrant commented Sep 30, 2025

Async executor removed. Firmware device api, fd_ops and fd_internal, will be in a Hubris driver task.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Sep 30, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@CourtneyDrant CourtneyDrant self-assigned this Sep 30, 2025
embediver
embediver reviewed Nov 5, 2025
View reviewed changes
Comment thread pldm-common/src/protocol/firmware_update.rs Outdated
embediver
embediver reviewed Nov 5, 2025
View reviewed changes
Comment thread pldm-interface/Cargo.toml
Comment thread src/timer.rs Outdated
Comment thread Cargo.toml
embediver
embediver requested changes Dec 10, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@embediver embediver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good now, a few small details still.

The added pldm-interface is hard to review in depth since documentation is missing mostly and there are no (unit-)tests.

We can merge it assuming that its good for now, but an issue regarding documentation and tests would be good.

Comment thread pldm-common/src/lib.rs Outdated
Comment thread pldm-interface/src/lib.rs Outdated
Comment thread src/lib.rs Outdated
Comment thread pldm-common/src/protocol/firmware_update.rs Outdated
@CourtneyDrant CourtneyDrant force-pushed the openprot branch 3 times, most recently from 8ecd2ad to 9bf3ee4 Compare December 17, 2025 22:57
@CourtneyDrant CourtneyDrant force-pushed the openprot branch 5 times, most recently from 0e82659 to bb8ac82 Compare December 18, 2025 01:21
@embediver
Copy link
Copy Markdown
Collaborator

embediver commented Dec 18, 2025

Looks good to me now 👍🏼

Just one small thing:
The CI wasn't configured for a cargo workspace environment, thus the tests only run on the root package.
Adding the --workspace option to the the cargo test invocation should be sufficient to also cover unit tests from the pldm-common and pldm-interface. All other checks should be ok as they are for now.
I noticed that one doc-test is failing when testing this, but the change is small, the import just needs to be changed from pldm_lib to pldm_common there.

@embediver
Copy link
Copy Markdown
Collaborator

embediver commented Dec 18, 2025

One doc test is failing in pldm-common/src/protocol/firmware_update.rs:356 f..

The import needs to be changed from pldm_lib to pldm_common.

@embediver embediver self-requested a review December 19, 2025 17:35
@CourtneyDrant CourtneyDrant merged commit 9062ba6 into OpenPRoT:main Jan 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embediver embediver embediver approved these changes

@rusty1968 rusty1968 Awaiting requested review from rusty1968

Assignees

@CourtneyDrant CourtneyDrant

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CourtneyDrant @embediver