Upgrade Thunder from v0.23.0 to v0.29.0 and align IdP bootstrap resources/configuration#260
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Thunder Identity Provider to v0.27.0 and aligning its configurations and bootstrap scripts to match the new version's behavior. The changes ensure a functional identity seed state for NSW portals and inter-service M2M flows, with an expanded sample data model for better representation of real-world scenarios. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully upgrades Thunder from v0.23.0 to v0.27.0. The changes are comprehensive, covering Docker image updates, environment configuration alignment, and a significant refactoring of the bootstrap scripts to match the new APIs and resource model of Thunder v0.27. The sample resources have also been thoughtfully expanded. The overall changes are well-executed. I have one suggestion to improve the maintainability of a bootstrap script by refactoring some duplicated code.
c81d0a7 to
f004335
Compare
f004335 to
08060cc
Compare
bde08d7 to
2f16ed5
Compare
…rces/configuration
10fed79 to
2819414
Compare
Summary
This PR upgrades Thunder from v0.23.0 to v0.27.0 and updates IdP bootstrap/configuration to match the v0.27 behavior and APIs.
The change includes:
Type of Change
What Changed
1. Thunder image upgrade
2. IdP bootstrap/runtime config alignment
3. Bootstrap script updates for Thunder v0.27
4. Brief summary of changes in idp/02-sample-resources.sh
The sample bootstrap now provisions a full multi-OU seed model and related identities/apps:
Creates organization-unit structure:
Creates user types:
Creates groups and roles:
Creates users and memberships:
Creates portal SPA applications:
Creates M2M applications (client_credentials):
Adds improved helper/idempotency handling:
Why
Related Issues
Related to #11 #12 #78 #224 #247 #248 #251
Validation Performed
Notes for Reviewers