Improve Primitives a Little Bit #2002
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA: Replace thrust::reduce with CUB DeviceReduce::Sum in primitives::sum
Summary
Inspired by this conversation here NVIDIA/cccl#520
Replaces the CUDA implementation of
primitives<Device::CUDA>::sumwithcub::DeviceReduce::SumusingcudaMallocAsyncfor temp storage. Interface and behavior are unchanged.While both Thrust and CUB use the same kernel backend, this removes the hidden sync cost of
cudaMallocin Thrust's default allocator path.This PR updates only
sum. Similar changes could be made formax,max_element,logsumexp, etc.Happy to share benchmarks if helpful!