Skip to content

Conversation

@Shahbaz-dataq
Copy link
Contributor

External References

@Shahbaz-dataq Shahbaz-dataq marked this pull request as ready for review January 6, 2026 17:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an issue where event configuration labels were getting cut off when they exceeded normal length. The fix removes the white-space: nowrap CSS property from table cells, allowing text to wrap naturally instead of being truncated.

Key changes:

  • Removed CSS constraint that prevented text wrapping in event configuration table
  • Refactored multiple test cases to use proper Pinia store isolation
  • Updated DOMParser mocking strategy in XML validator tests to use class syntax with vi.stubGlobal

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ui/src/components/EventConfigurationDetail/EventConfigEventTable.vue Removed white-space: nowrap CSS property to allow long event labels to wrap
ui/tests/components/EventConfigurationDetail/Dialog/DeleteEventConfigSourceDialog.test.ts Refactored test to create isolated Pinia instance and local wrapper for null eventConfigSource scenario
ui/tests/components/EventConfigurationDetail/Dialog/DeleteEventConfigEventDialog.test.ts Refactored test to create isolated Pinia instance with proper state initialization for missing IDs scenario
ui/tests/components/EventConfiguration/Dialog/DeleteEventConfigSourceDialog.test.ts Refactored test with complete store state initialization and isolated wrapper for null eventConfigSource test
ui/tests/components/EventConfiguration/BasicInformation.test.ts Enhanced test to properly invalidate form before verifying save behavior
ui/tests/components/EventConfiguration/eventConfigXmlValidator.test.ts Migrated DOMParser mocks from function syntax to class syntax using vi.stubGlobal, added vi.unstubAllGlobals cleanup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@synqotik synqotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shahbaz-dataq Shahbaz-dataq merged commit 2f7e63f into release-35.x Jan 7, 2026
6 checks passed
@Shahbaz-dataq Shahbaz-dataq deleted the jira/NMS-19359 branch January 7, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants