fix: gate mail preview + remove dead category route#553
Merged
tompscanlan merged 2 commits intomainfrom Mar 8, 2026
Merged
Conversation
The GET /api/mail/preview endpoint was completely open in production. Add TestOnlyGuard and ApiExcludeController decorators, and split MailController into a separate MailPreviewModule that is only loaded in non-production environments (matching TestHelpersModule pattern). Closes om-qfr3
The findOne route only supported numeric ID lookups, causing 500 errors when slugs were passed (NaN coercion). The endpoint was never called by the frontend (dead code since PR #143, Nov 2024). Remove it entirely. Closes om-3f68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestOnlyGuard+ApiExcludeController, split intoMailPreviewModuleconditionally loaded in non-production (matchingTestHelpersModulepattern). Mail service remains available in all environments.GET /categories/:idroute that caused 500 errors when slugs were passed (NaN coercion). Never called by frontend since PR chore: changed all endpoints to slug oriented (group,event,user) #143 (Nov 2024).Test plan
TestOnlyGuardandApiExcludeControllermetadata appliedfindOneroute no longer exists