fix(security): prevent untrusted ATProto email from overwriting user data#551
Merged
tompscanlan merged 5 commits intomainfrom Mar 5, 2026
Merged
fix(security): prevent untrusted ATProto email from overwriting user data#551tompscanlan merged 5 commits intomainfrom
tompscanlan merged 5 commits intomainfrom
Conversation
Bluesky/ATProto PDS can self-report emailConfirmed=true for any email. Never overwrite an existing user's email based on ATProto OAuth data. Issue: om-ibft
PDS-reported emailConfirmed is untrusted. Force it to false early in findOrCreateUser() so email is stored but never treated as verified. Users still get ACTIVE status via DID identity proof. Issue: om-ibft
Switch tests that verified email-update and activation behavior to use Google provider (trusted). Bluesky email trust is now covered by new security tests. Update Email Handling tests to expect INACTIVE status when Bluesky provides email without trusted verification. Issue: om-ibft
Verify Google OAuth can still update user email (trusted provider). Issue: om-ibft
Fix prettier formatting and unused variable in test added by e654272. Issue: om-ibft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findOrCreateUser()for Bluesky/ATProto providers — a malicious PDS can self-reportemailConfirmed=truefor any emailprofile.emailConfirmed = falseearly infindOrCreateUser()for ATProto providers so email is stored but never treated as verified!isUntrustedEmailProviderguard protect the email-overwrite pathTest Plan
emailConfirmed=true