feat(atproto): local handle resolution fallback in custom fetch#504
Draft
tompscanlan wants to merge 1 commit intomainfrom
Draft
feat(atproto): local handle resolution fallback in custom fetch#504tompscanlan wants to merge 1 commit intomainfrom
tompscanlan wants to merge 1 commit intomainfrom
Conversation
Extend createPlcFallbackFetch() to intercept .well-known/atproto-did requests for handles matching PDS_SERVICE_HANDLE_DOMAINS. Tries the canonical DNS/.well-known path first (3s timeout), then falls back to the local PDS com.atproto.identity.resolveHandle XRPC method. This fixes OAuth flows for custodial users with .pds.test handles in local Docker environments where no DNS exists for the handle domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createPlcFallbackFetch()to intercept.well-known/atproto-didrequests for handles matchingPDS_SERVICE_HANDLE_DOMAINScom.atproto.identity.resolveHandle.pds.testhandles in local Docker dev (no DNS for handle domain)PDS_URLandPDS_SERVICE_HANDLE_DOMAINSfrom config ininitializeOAuthClient()How it works
In dev/prod where DNS works, the normal path succeeds and PDS is never called.
Test plan