fix_xdg: ensure write permissions before modifying .desktop files#6
Open
neurofreak-alt wants to merge 1 commit intoOpenMandrivaSoftware:masterfrom
Open
fix_xdg: ensure write permissions before modifying .desktop files#6neurofreak-alt wants to merge 1 commit intoOpenMandrivaSoftware:masterfrom
neurofreak-alt wants to merge 1 commit intoOpenMandrivaSoftware:masterfrom
Conversation
Add a check to verify that each .desktop file is writable before attempting to modify it with sed. If the file is not writable, try to set the user-writeable bit (u+w). If this fails, skip the file instead of aborting the entire script. This prevents build failures when input files are read-only, improving robustness in RPM build environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check to verify that each .desktop file is writable before attempting to modify it with sed. If the file is not writable, try to set the user-writeable bit (u+w). If this fails, skip the file instead of aborting the entire script.
This prevents build failures when input files are read-only, improving robustness in RPM build environments.