Skip to content

Fix needed for the NPSS example #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kenneth-T-Moore wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix needed for the NPSS example #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f50edbc
Fix needed for the NPSS example
Kenneth-T-Moore Jan 23, 2026
a9bd72c
Merge branch 'main' into npss
Kenneth-T-Moore Jan 27, 2026
6ac1166
Merge branch 'main' of github.com:OpenMDAO/Aviary into npss
Kenneth-T-Moore Jan 30, 2026
bed848e
Added more info about interp method to the metadata
Kenneth-T-Moore Jan 30, 2026
a1d2cdc
Added more info about interp method to the metadata
Kenneth-T-Moore Jan 30, 2026
b374394
Merge branch 'npss' of github.com:Kenneth-T-Moore/aviary into npss
Kenneth-T-Moore Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aviary/models/aircraft/advanced_single_aisle/advanced_single_aisle_FLOPS.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ aircraft:engine:fuel_flow_scaler_linear_term,1,unitless
aircraft:engine:generate_flight_idle,True,unitless
aircraft:engine:geopotential_alt,False,unitless
aircraft:engine:ignore_negative_thrust,False,unitless
aircraft:engine:interpolation_method,slinear,unitless
Copy link
Contributor

@cmbenne3 cmbenne3 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kenneth-T-Moore - Perhaps we could update the variable_meta_data.py with a link to the openMDAO page documentation so that someone can easily work out what methods are available.

Image I think this is the doc link: https://openmdao.org/newdocs/versions/latest/features/building_blocks/components/metamodelstructured_comp.html

Does OpenMDAO have enums that we can import? Might get a bit messy if we make this an Aviary enum (in case OpenMDAO makes updates) so I think best to keep as a string for now - what do you think?

Copy link
Member Author

@Kenneth-T-Moore Kenneth-T-Moore Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've kind of been wanting to modify OpenMDAO to use enums for all of the interpolation methods.

aircraft:engine:mass_scaler,1.15,unitless
aircraft:engine:num_engines,2,unitless
aircraft:engine:num_fuselage_engines,0,unitless
Expand Down
5 changes: 4 additions & 1 deletion aviary/variable_info/variable_meta_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2166,7 +2166,10 @@
default_value='slinear',
types=str,
desc="method used for interpolation on an engine deck's data file, allowable values are "
'table methods from openmdao.components.interp_util.interp',
'table methods from openmdao.components.interp_util.interp. Engine models only use the '
'methods avilable to the MetaModelSemiStructuredComp component. These are listed here: '
'https://openmdao.org/newdocs/versions/latest/features/building_blocks/components/'
'metamodelsemistructured_comp.html',
multivalue=True,
)

Expand Down
Loading