-
Notifications
You must be signed in to change notification settings - Fork 111
Mass report update - FLOPS #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkirk5
wants to merge
40
commits into
OpenMDAO:main
Choose a base branch
from
jkirk5:reports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviary/models/aircraft/large_single_aisle_2/large_single_aisle_2_altwt_FLOPS_data.py
Outdated
Show resolved
Hide resolved
Fixed missing propulsion mass entry
Added missed rename for cabin crew
Kenneth-T-Moore
approved these changes
Jan 20, 2026
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised the variable match test didn't find more mistakes in the names. Guess they are all good now.
Note: there is a test regression that should be investigated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates mass reporting for FLOPS-based mass to conform to SAWE RP-8 standard.
Some mass variables have been renamed to comply with the standard, and the FLOPS-based mass summation component was reworked to group masses appropriately.
Generative AI was used to write a new test that checks matching between hierarchy variable names and string representation (test_var_structure.py). The Cursor IDE was used, which does not expose which specific models it uses. Manual review and minor tweaks were done by hand.
Related Issues
Backwards incompatibilities
Renamed variables:
Aircraft.CrewPayload.NUM_TOURIST_CLASS->Aircraft.CrewPayload.NUM_ECONOMY_CLASSAircraft.CrewPayload.NON_FLIGHT_CREW_MASS->Aircraft.CrewPayload.CABIN_CREW_MASSAircraft.CrewPayload.NON_FLIGHT_CREW_MASS_SCALER->Aircraft.CrewPayload.CABIN_CREW_MASS_SCALERAircraft.CrewPayload.PASSENGER_MASS->Aircraft.CrewPayload.PASSENGER_MASS_TOTALAircraft.CrewPayload.PASSENGER_MASS_WITH_BAGS->Aircraft.CrewPayload.MASS_PER_PASSENGER_WITH_BAGSAircraft.Controls.TOTAL_MASS->Aircraft.Controls.MASSAircraft.Design.SYSTEMS_EQUIP_MASS->Aircraft.Design.SYSTEMS_AND_EQUIPMENT_MASSAircraft.Design.SYSTEMS_EQUIP_MASS_BASE->Aircraft.Design.SYSTEMS_AND_EQUIPMENT_MASS_BASEAircraft.Wing.ASPECT_RATIO_REF->Aircraft.Wing.ASPECT_RATIO_REFERENCEAircraft.Wing.THICKNESS_TO_CHORD_REF->Aircraft.Wing.THICKNESS_TO_CHORD_REFERENCENew Dependencies
None