Skip to content

fix(previews): respect download priority for iframe previews #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrgzs merged 1 commit into from
Jan 2, 2026
Merged

fix(previews): respect download priority for iframe previews #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/pages/home/previews/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,16 @@ export const getPreviews = (
}
// iframe previews
const iframePreviews = getIframePreviews(file.name)
res.push(
...iframePreviews.map((preview) => ({
name: preview.key,
component: generateIframePreview(preview.value),
})),
)
const matchedIframePreviews = iframePreviews.map((preview) => ({
name: preview.key,
component: generateIframePreview(preview.value),
}))
// Condition for iframe previews to respect the "preview_download_by_default" setting
if (downloadPrior) {
subsequent.push(...matchedIframePreviews)
} else {
res.push(...matchedIframePreviews)
}

// download page
const downloadComponent: PreviewComponent = {
Expand Down