Skip to content

fix: resolve warnings and cleanup code#161

Open
mikecarr wants to merge 3 commits intodevfrom
fix/warnings-cleanup
Open

fix: resolve warnings and cleanup code#161
mikecarr wants to merge 3 commits intodevfrom
fix/warnings-cleanup

Conversation

@mikecarr
Copy link
Member

@mikecarr mikecarr commented Mar 12, 2026

Summary

  • Fix warnings across the codebase
  • Update dialogs and scan command initialization fixes
  • Merge conflict resolution: use OpenIPC.AppDataConfigPath in CheckForUpdatesAsync, keep DefaultLatestJsonUrl fallback in UpdateChecker, and retain Greg APFPV firmware source logic in FirmwareTabViewModel

Test plan

  • Build in release mode and verify no new warnings
  • Verify update check runs on startup in release build
  • Verify Greg APFPV firmware source still works
  • Verify scan command initializes correctly

🤖 Generated with Claude Code

mikecarr and others added 3 commits January 24, 2026 08:06
@mikecarr
Fix warnings and update dialogs
1810d0b
@mikecarr
Fix scan command initialization
66a34b2
@mikecarr @claude
chore: merge origin/dev and resolve conflicts
a586738 
- Use OpenIPC.AppDataConfigPath in CheckForUpdatesAsync (App.axaml.cs)
- Use DefaultLatestJsonUrl fallback in UpdateChecker
- Keep Greg APFPV firmware source logic in FirmwareTabViewModel

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mikecarr