Skip to content

Exclude validations#5

Open
ppbconn wants to merge 3 commits intoOpenHoldem:masterfrom
ppbconn:excludeValidations
Open

Exclude validations#5
ppbconn wants to merge 3 commits intoOpenHoldem:masterfrom
ppbconn:excludeValidations

Conversation

@ppbconn
Copy link
Copy Markdown

@ppbconn ppbconn commented Jan 10, 2016

Hi,
This is a proposal and implementation of a small feature. It allows explicitly excluding validation tests and keep the other tests running. I find it helpful when certain tests are failing not because of the wrong tablemap but because differences between poker rooms. It is also very helpful to debug the table map when there are a lot of scrapping errors, the user can clear the errors one by one without having to deal with multiple popups.
thanks,
pbconn.

@ppbconn ppbconn closed this Jan 10, 2016
@ppbconn ppbconn reopened this Jan 10, 2016
@ppbconn
Copy link
Copy Markdown
Author

ppbconn commented Feb 2, 2016

Hi,
I am wondering if you are considering accepting/rejecting this pull request...

Thanks

@TheHighFish
Copy link
Copy Markdown

We have been "a bit slow", I am very sorry.
ATM large parts of OH get heavily rewritten, so the patch is no longer applicable, unfortunately.
I will ocnsider porting it once the new, modular OH has been released, as i consider this a good feature.
New pull-requests will be handled faster, I now deal with all the old ones.

@rub3r0id
Copy link
Copy Markdown

rub3r0id commented Oct 9, 2024

@Mudr0x, @SalemMaxInMontreal I think it's obsolete and can be closed, but maybe you have another opinion

@Mudr0x
Copy link
Copy Markdown

Mudr0x commented Oct 10, 2024

I will take a look if thoses fixes can be adapted to actual OH code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants