Conversation
* Set backfill_changesets default behaviour to backfill the last day changesets * Fix test command arguments * Fix typo * Fix start_date and end_date access
Bumps [sqlparse](https://github.com/andialbrecht/sqlparse) from 0.4.2 to 0.4.4. - [Changelog](https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG) - [Commits](andialbrecht/sqlparse@0.4.2...0.4.4) --- updated-dependencies: - dependency-name: sqlparse dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Switch to oauth2 authentication * Update ChangesetCommentAPI to use oauth2 * FIx comment api tests * Update social-user's extra_data param in tests * Update tests to oauth2 fields * Fix client.post and token check
* Update DRF-gis to 1.0 * Remove celery * Remove BROKER_URL from config
* Set user-agent when making requests to the OSM API * Add header to test mock * Fix get display_name * Fix error in users.tests.test_utils
This allows us to monitor the API health more easily from a remote service such as updown.io.
) Followup on commit 2991254 which removed the management commands necessary for serving the frontend via Django. The supported workflow is now to deploy the frontend separately and configure it to talk to this Django app. If desired, both can be served by an Nginx proxy (which serves static files for the frontend and proxies /api requests to Django).
This brings the local dev environment closer to production by using the same frontend container. It also changes the backend to serve with gunicorn by default, even in dev mode. Also, static files are now always served by the frontend and never by Django, even in dev mode.
Improve Docker development workflow
* Update views.py * Update test_changeset_views.py
This endpoint recieves a large volume of requests (one for each new changeset) from a single admin user account. Rate-limiting it will cause tag-changes data to stop being ingested during periods when there are lots of edits happening in OSM, which isn't desirable.
The DRF Serializer for the Changeset model was using obj.tags.filter() and obj.reasons.filter() to filter the lists of reasons and tags (only showing enabled ones to non-staff users). This had the probably unexpected consequence of generating an additional two database queries for each changeset in the resulting list. The reasons and tags related fields were being prefetched, but prefetching only works for iterating the entire relation. The fix for this problem is straightforward: instead of using .filter(), we can just filter the reasons and tags in Python. This allows the prefetching to work as intended and avoids the additional queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.