Replace mapbox-gl-language with Diplomat #39
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
commented
Dec 23, 2025
index.js
Outdated
| localizedNamePropertyFormat: "name_$1", | ||
| }); | ||
| localizeStyle(map, getLocales(), { | ||
| localizedNamePropertyFormat: "name_$1", |
Member
Author
There was a problem hiding this comment.
Unusually, the OHM tile schema’s format for localized name properties uses underscores instead of hyphens inside language tags, contrary to the IETF BCP 47 standard. Even other tilesets that use underscores, like Shortbread and Mapbox Streets, still use hyphens inside language tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced mapbox-gl-language with Diplomat for localizing labels into the user’s preferred language. Appended a gloss with the contemporary local language to any localized name.
This is blocked by maplibre/maplibre-gl-js#6903.
Also, Diplomat is designed to add the gloss only to populated places, but many administrative areas in OHM are still mapped redundantly as both boundary relations and place points, mimicking populated places. These redundant place points should be deleted. Until then, the display will be fairly cluttered.